[PATCH v1 4/7] drivers: Reorder headers alphabetically
"Ahmed S. Darwish" <[email protected]>
| Newsgroups | dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Multiple drivers use the cpuid_*() macros, but implicitly include the main CPUID header through <asm/processor.h> instead. Sort their include lines so that <asm/cpuid/api.h> can be explicitly included next. Signed-off-by: Ahmed S. Darwish <[email protected]> --- drivers/cpufreq/longrun.c | 6 +++--- drivers/cpufreq/powernow-k7.c | 13 ++++++------- drivers/cpufreq/powernow-k8.c | 16 ++++++++-------- drivers/cpufreq/speedstep-lib.c | 5 +++-- drivers/hwmon/fam15h_power.c | 13 +++++++------ drivers/hwmon/k8temp.c | 11 ++++++----- drivers/thermal/intel/x86_pkg_temp_thermal.c | 14 +++++++------- 7 files changed, 40 insertions(+), 38 deletions(-) diff --git a/drivers/cpufreq/longrun.c b/drivers/cpufreq/longrun.c index 1caaec7c280b..263c48b8f628 100644 --- a/drivers/cpufreq/longrun.c +++ b/drivers/cpufreq/longrun.c @@ -5,15 +5,15 @@ * BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous* */ +#include <linux/cpufreq.h> +#include <linux/init.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/init.h> -#include <linux/cpufreq.h> #include <linux/timex.h> +#include <asm/cpu_device_id.h> #include <asm/msr.h> #include <asm/processor.h> -#include <asm/cpu_device_id.h> static struct cpufreq_driver longrun_driver; diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c index 31039330a3ba..0608040fcd1e 100644 --- a/drivers/cpufreq/powernow-k7.c +++ b/drivers/cpufreq/powernow-k7.c @@ -15,20 +15,20 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/cpufreq.h> +#include <linux/dmi.h> +#include <linux/init.h> +#include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/init.h> -#include <linux/cpufreq.h> #include <linux/slab.h> #include <linux/string.h> -#include <linux/dmi.h> #include <linux/timex.h> -#include <linux/io.h> -#include <asm/timer.h> /* Needed for recalibrate_cpu_khz() */ -#include <asm/msr.h> #include <asm/cpu_device_id.h> +#include <asm/msr.h> +#include <asm/timer.h> /* Needed for recalibrate_cpu_khz() */ #ifdef CONFIG_X86_POWERNOW_K7_ACPI #include <linux/acpi.h> @@ -691,4 +691,3 @@ MODULE_LICENSE("GPL"); late_initcall(powernow_init); module_exit(powernow_exit); - diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index f7512b4e923e..2b5cdd8f1c0a 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -26,22 +26,22 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/acpi.h> +#include <linux/cpufreq.h> +#include <linux/cpumask.h> +#include <linux/delay.h> +#include <linux/init.h> +#include <linux/io.h> #include <linux/kernel.h> -#include <linux/smp.h> #include <linux/module.h> -#include <linux/init.h> -#include <linux/cpufreq.h> +#include <linux/mutex.h> #include <linux/slab.h> +#include <linux/smp.h> #include <linux/string.h> -#include <linux/cpumask.h> -#include <linux/io.h> -#include <linux/delay.h> #include <asm/msr.h> #include <asm/cpu_device_id.h> -#include <linux/acpi.h> -#include <linux/mutex.h> #include <acpi/processor.h> #define VERSION "version 2.20.00" diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c index 0b66df4ed513..f08817331aec 100644 --- a/drivers/cpufreq/speedstep-lib.c +++ b/drivers/cpufreq/speedstep-lib.c @@ -9,14 +9,15 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/cpufreq.h> +#include <linux/init.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/moduleparam.h> -#include <linux/init.h> -#include <linux/cpufreq.h> #include <asm/msr.h> #include <asm/tsc.h> + #include "speedstep-lib.h" #define PFX "speedstep-lib: " diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index 8ecebea53651..5a5674e85f63 100644 --- a/drivers/hwmon/fam15h_power.c +++ b/drivers/hwmon/fam15h_power.c @@ -6,20 +6,21 @@ * Author: Andreas Herrmann <[email protected]> */ +#include <linux/bitops.h> +#include <linux/cpu.h> +#include <linux/cpumask.h> #include <linux/err.h> -#include <linux/hwmon.h> #include <linux/hwmon-sysfs.h> +#include <linux/hwmon.h> #include <linux/init.h> #include <linux/module.h> #include <linux/pci.h> -#include <linux/bitops.h> -#include <linux/cpu.h> -#include <linux/cpumask.h> -#include <linux/time.h> #include <linux/sched.h> +#include <linux/time.h> #include <linux/topology.h> -#include <asm/processor.h> + #include <asm/msr.h> +#include <asm/processor.h> MODULE_DESCRIPTION("AMD Family 15h CPU processor power monitor"); MODULE_AUTHOR("Andreas Herrmann <[email protected]>"); diff --git a/drivers/hwmon/k8temp.c b/drivers/hwmon/k8temp.c index 2b80ac410cd1..8c1efce9a04b 100644 --- a/drivers/hwmon/k8temp.c +++ b/drivers/hwmon/k8temp.c @@ -7,13 +7,14 @@ * Inspired from the w83785 and amd756 drivers. */ -#include <linux/module.h> -#include <linux/init.h> -#include <linux/slab.h> -#include <linux/pci.h> -#include <linux/hwmon.h> #include <linux/err.h> +#include <linux/hwmon.h> +#include <linux/init.h> +#include <linux/module.h> #include <linux/mutex.h> +#include <linux/pci.h> +#include <linux/slab.h> + #include <asm/processor.h> #define TEMP_FROM_REG(val) (((((val) >> 16) & 0xff) - 49) * 1000) diff --git a/drivers/thermal/intel/x86_pkg_temp_thermal.c b/drivers/thermal/intel/x86_pkg_temp_thermal.c index 3fc679b6f11b..c843cb5fc5c3 100644 --- a/drivers/thermal/intel/x86_pkg_temp_thermal.c +++ b/drivers/thermal/intel/x86_pkg_temp_thermal.c @@ -5,19 +5,19 @@ */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -#include <linux/module.h> +#include <linux/cpu.h> +#include <linux/debugfs.h> +#include <linux/device.h> +#include <linux/err.h> #include <linux/init.h> #include <linux/intel_tcc.h> -#include <linux/err.h> +#include <linux/module.h> #include <linux/param.h> -#include <linux/device.h> #include <linux/platform_device.h> -#include <linux/cpu.h> -#include <linux/smp.h> -#include <linux/slab.h> #include <linux/pm.h> +#include <linux/slab.h> +#include <linux/smp.h> #include <linux/thermal.h> -#include <linux/debugfs.h> #include <asm/cpu_device_id.h> #include <asm/msr.h> -- 2.49.0