Re: [PATCH v4 02/34] ASoC: Intel: avs: Include CPUID header at file scope
Borislav Petkov <[email protected]>
| Newsgroups | dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20250818145646.GGaKM_Ltrggbwkj2TB@fat_crate.local> |
On Fri, Aug 15, 2025 at 09:01:55AM +0200, Ahmed S. Darwish wrote:
> Commit
>
> cbe37a4d2b3c ("ASoC: Intel: avs: Configure basefw on TGL-based platforms")
>
> includes the main CPUID header from within a C function. This works by
> luck and forbids valid refactorings inside the CPUID header.
>
> Include the CPUID header at file scope instead.
>
> Note, for the CPUID(0x15) leaf number, use CPUID_LEAF_TSC instead of
> defining a custom local macro for it.
>
> Signed-off-by: Ahmed S. Darwish <[email protected]>
> Acked-by: Cezary Rojewski <[email protected]>
> ---
> sound/soc/intel/avs/tgl.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
I'm guessing that:
https://lore.kernel.org/r/aGv8AWwHbi5seDxi@lx-t490
still needs to happen yet?
Because I don't see it in this set...
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette