[PATCH v5 11/35] x86/cpu: Use parsed CPUID(0x1)
"Ahmed S. Darwish" <[email protected]> Fri, 5 Sep 2025 14:14:51 +0200
| Newsgroups | dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
At the early boot CPU detection code, use parsed CPUID(0x1) access instead of a direct CPUID query. Beside the CPUID parser centralization benefits, this allows using the auto-generated <asm/cpuid/leaf_types.h> data types, and their full C99 bitfields, instead of doing ugly bitwise operations on CPUID register output. Signed-off-by: Ahmed S. Darwish <[email protected]> --- arch/x86/kernel/cpu/common.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index e081f92ddfe9..f989c8099490 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -897,6 +897,7 @@ void get_cpu_vendor(struct cpuinfo_x86 *c) void cpu_detect(struct cpuinfo_x86 *c) { const struct leaf_0x0_0 *l0 = cpuid_leaf(c, 0x0); + const struct leaf_0x1_0 *l1 = cpuid_leaf(c, 0x1); c->cpuid_level = l0->max_std_leaf; *(u32 *)&c->x86_vendor_id[0] = l0->cpu_vendorid_0; @@ -904,17 +905,14 @@ void cpu_detect(struct cpuinfo_x86 *c) *(u32 *)&c->x86_vendor_id[8] = l0->cpu_vendorid_2; c->x86 = 4; - /* Intel-defined flags: level 0x00000001 */ - if (c->cpuid_level >= 0x00000001) { - u32 junk, tfms, cap0, misc; - cpuid(0x00000001, &tfms, &misc, &junk, &cap0); - c->x86 = x86_family(tfms); - c->x86_model = x86_model(tfms); - c->x86_stepping = x86_stepping(tfms); + if (l1) { + c->x86 = cpuid_family(l1); + c->x86_model = cpuid_model(l1); + c->x86_stepping = l1->stepping; - if (cap0 & (1<<19)) { - c->x86_clflush_size = ((misc >> 8) & 0xff) * 8; + if (l1->clflush) { + c->x86_clflush_size = l1->clflush_size * 8; c->x86_cache_alignment = c->x86_clflush_size; } } -- 2.50.1