Re: [PATCH v7 026/120] x86/cpuid: Warn once on invalid CPUID(0x2) iteration count

Maciej Wieczor-Retman <[email protected]> Mon, 1 Jun 2026 19:36:46 +0200
Newsgroups dev.linux.lists.x86-cpuid,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 2026-05-28 at 17:37:48 +0200, Ahmed S. Darwish wrote:
...
>--- a/arch/x86/kernel/cpu/cpuid_parser.c
>+++ b/arch/x86/kernel/cpu/cpuid_parser.c
>@@ -3,6 +3,8 @@
>  * CPUID parser; for populating the system's CPUID tables.
>  */
> 
>+#define pr_fmt(fmt) "x86/cpuid: " fmt
>+
> #include <linux/kernel.h>
> 
> #include <asm/cpuid/api.h>
>@@ -54,8 +56,11 @@ cpuid_read_0x2(const struct cpuid_parse_entry *e, const struct cpuid_read_output
> 	 * keep the leaf marked as invalid at the CPUID table.
> 	 */
> 	cpuid_read_subleaf(e->leaf, e->subleaf, l);
>-	if (l->iteration_count != 0x01)
>+	if (l->iteration_count != 0x01) {
>+		pr_warn_once("Ignoring CPUID(0x2) due to invalid iteration count = %d",
>+			     l->iteration_count);

I think a '\n' new line is missing at the end of the format string

-- 
Kind regards
Maciej Wieczór-Retman