Re: [PATCH RFC xenomai-images 5/5] recipes-kernel: add debug additions to riscv64_defconfig
Tobias Schaffner <[email protected]>
| Newsgroups | dev.linux.lists.xenomai |
|---|---|
| Message-ID | <[email protected]> |
Hi Jan, On 4/20/26 07:47, Jan Kiszka wrote: > On 17.04.26 22:57, Tobias Schaffner wrote: >> Added to the defconfig to support the current workflow with a debug >> disablement snippet. >> >> Added as a section in the end of the file to make factoring out debug >> configs at a later stage easier. >> >> Signed-off-by: Tobias Schaffner <[email protected]> >> --- >> recipes-kernel/linux/files/common_nodbg.cfg | 2 ++ >> recipes-kernel/linux/files/riscv64_defconfig | 15 +++++++++++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/recipes-kernel/linux/files/common_nodbg.cfg b/recipes-kernel/linux/files/common_nodbg.cfg >> index a57463b..6637d16 100644 >> --- a/recipes-kernel/linux/files/common_nodbg.cfg >> +++ b/recipes-kernel/linux/files/common_nodbg.cfg >> @@ -1,5 +1,7 @@ >> # CONFIG_IPIPE_DEBUG is not set >> # CONFIG_XENO_OPT_DEBUG is not set >> +# CONFIG_EVL_DEBUG is not set >> +# CONFIG_EVL_DEBUG_CORE is not set >> # CONFIG_DEBUG_VM is not set >> # CONFIG_DEBUG_LIST is not set >> # CONFIG_BUG_ON_DATA_CORRUPTION is not set >> diff --git a/recipes-kernel/linux/files/riscv64_defconfig b/recipes-kernel/linux/files/riscv64_defconfig >> index 8f9e852..6b991ae 100644 >> --- a/recipes-kernel/linux/files/riscv64_defconfig >> +++ b/recipes-kernel/linux/files/riscv64_defconfig >> @@ -311,3 +311,18 @@ CONFIG_DEBUG_KERNEL=y >> CONFIG_DEBUG_FS=y >> # CONFIG_RUNTIME_TESTING_MENU is not set >> CONFIG_MEMTEST=y >> + >> + >> +# Debug additions >> +CONFIG_BUG_ON_DATA_CORRUPTION=y >> +CONFIG_DEBUG_ATOMIC_SLEEP=y >> +CONFIG_DEBUG_LIST=y >> +CONFIG_DEBUG_LOCK_ALLOC=y >> +CONFIG_DEBUG_VM=y >> +CONFIG_DYNAMIC_FTRACE=y >> +CONFIG_EVL_DEBUG=y >> +CONFIG_EVL_DEBUG_CORE=y >> +CONFIG_FTRACE=y >> +CONFIG_FUNCTION_TRACER=y >> +CONFIG_PROVE_LOCKING=y >> +CONFIG_STACKTRACE=y > > I vaguely recall an attempt to invert this logic to "base config + > common_debug.cfg" - what happened to it? But that's independent, no > comments on this change. That is one of the reasons I tagged this as RFC, and I tried to start a discussion about that in the cover letter. The RFC for debug config snippet logic inversion was: "Rework linux-xenomai debug configuration". When I started the rework, I tried to invert the logic without any changes to the resulting debug and nodebug configs. The idea was to make sure not to change the build behavior for any users of this layer. But the "defconfigs" of the other architectures are not defconfigs but large configs that grew over time. For a lot of the switches, it is unknown why they were added and if they are still needed, right? With a common debug snippet that makes sure all of these are set exactly as before in the debug and nodebug case, the debug snippet gets huge (check the RFC for reference), like 450 lines big (including comments but still...). Now that I want to create the snippets for RISC-V, I am unwilling to pull in all of that into the riscv config. Even if we find ways to optimize this to <100 switches, it is still too much. Best, Tobias > > Jan >