Re: [PATCH] testsuite/xeno-test: Fix clocktest invocation

On 13.05.26 14:49, Florian Bezdeka wrote:
> The -D cmdline switch and CLOCK_HOST_REALTIME support has been removed
> in commit
> e3a3a3025b14 ("testsuite/clocktest: Drop obsolete CLOCK_HOST_REALTIME
>                and wallclock offset bits")
> 
> so that an invocation with -D resulted in the help message.
> Taken from one of our LAVA test logs:
> 
>  + /usr/lib/xenomai/testsuite/clocktest -D -T 30 -C CLOCK_HOST_REALTIME
>  usage: clocktest [options]
>    [-C <clock_id|clock_name>]   # tested clock, defaults to CLOCK_REALTIME
>    [-E]                         # -C specifies extension clock
>    [-T <test_duration_seconds>] # default=0, so ^C to end
>  + /usr/lib/xenomai/testsuite/clocktest -T 30
> 
> Removing the first and unnecessary call to clocktest to clean up tests.
> 
> Fixes: e3a3a3025b14 ("testsuite/clocktest: Drop obsolete                       CLOCK_HOST_REALTIME and wallclock offset bits")
> Signed-off-by: Florian Bezdeka <[email protected]>
> ---
> Hi all,
> 
> During reviews and some code reading some minor regressions in the
> testsuite came to light.
> 
> Cc: Jan Kiszka <[email protected]>
> ---
>  testsuite/xeno-test/xeno-test.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testsuite/xeno-test/xeno-test.in b/testsuite/xeno-test/xeno-test.in
> index 590eac1e0378309e5a8cfeafac3654bef86fd231..de2749c84592d218889a95cd7bc615aa3f0cae2f 100644
> --- a/testsuite/xeno-test/xeno-test.in
> +++ b/testsuite/xeno-test/xeno-test.in
> @@ -108,7 +108,7 @@ fi
>  
>  start_timesyncd
>  
> -$testdir/clocktest -D -T 30 -C CLOCK_HOST_REALTIME || $testdir/clocktest -T 30
> +$testdir/clocktest -T 30
>  $testdir/switchtest -T 30
>  
>  start_load
> 
> ---
> base-commit: 54e9c509863439614484b0bf939c32bfadb15423
> change-id: 20260508-wip-flo-drive-by-fixes-c51c8be9a7b1
> 
> Best regards,

Thanks, applied.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center