[PATCH 0/2] arm: Review irq pipeline

Florian Bezdeka <[email protected]>
Newsgroups dev.linux.lists.xenomai
Message-ID <[email protected]>
Hi Philippe,

This is the result of a review of the arm implementation of the IRQ
pipeline. Triggered by some risc-v reviews.

I'm sure about the two easy fixes, targeting different Dovetail
versions, so split into different patches.

In addition there is one more, I need your input here:

We have two calls to interrupts_enabled() in arch/arm/mm/fault.c,
both in the do_page_fault() path.

Assuming that we are handling a page fault over kernel space,
inband stage stalled, we would leave the kernel with the inband stage
unstalled, as interrupts_enabled() is checking the hardware state (as
pushed to the stack on entry) instead of the inband stage stall bit.

Is that correct?

I'm quite sure we have more real problems that in this case, but
maybe we should fix that up?

We would have to call something that does the HW check in case
CONFIG_IRQ_PIPELINE is off, but checks the stall bit in case pipelining
is enabled.

To: [email protected]
Cc: Philippe Gerum <[email protected]>
Cc: Tobias Schaffner <[email protected]>

Signed-off-by: Florian Bezdeka <[email protected]>
---
Florian Bezdeka (2):
      arm: irq_pipeline: Fix fault_{entry,exit} imbalance
      arm: irq_pipeline: Fix fault_{entry,exit} imbalance

 arch/arm/mm/fault.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 5c4243abc449083b74c94fcd353d360b6ce78b5b
change-id: 20260603-wip-flo-v7-1-arm-fixups-25d58fb72f3e

Best regards,
-- 
Florian Bezdeka <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.