Re: [PATCH dovetail v9 11/11] riscv: dovetail: add core support

On Mon, 2026-07-06 at 19:16 +0200, Tobias Schaffner wrote:
> On 7/6/26 17:06, Florian Bezdeka wrote:
> > On Fri, 2026-07-03 at 17:27 +0200, Tobias Schaffner wrote:
> > > @@ -359,6 +391,15 @@ void do_trap_ecall_u(struct pt_regs *regs)
> > >   
> > >   		syscall = syscall_enter_from_user_mode(regs, syscall);
> > >   
> > > +		if(dovetailing()) {
> > 
> > checkpatch:
> > 
> > ERROR: space required before the open parenthesis '('
> > #1426: FILE: arch/riscv/kernel/traps.c:394:
> > +		if(dovetailing()) {
> > 
> > 
> > Please double check checkpatch output for the complete series, there
> > seems room for improvement.
> 
> Ah... That's the only checkpatch comlain. I will send a new version.

Looking at the complete series there is more...

The most important ones (on v10):

WARNING: function definition argument 'struct pt_regs *' should also
have an identifier name
#271: FILE: arch/riscv/include/asm/irq_pipeline.h:131:
+extern void (*handle_arch_irq)(struct pt_regs *);

WARNING: Missing a blank line after declarations
#682: FILE: arch/riscv/kernel/traps.c:455:
+	struct pt_regs *old_regs = set_irq_regs(regs);
+	handle_arch_irq(regs);

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1174: FILE: arch/riscv/include/asm/dovetail.h:1:
+/*

WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1175: FILE: arch/riscv/include/asm/dovetail.h:2:
+* SPDX-License-Identifier: GPL-2.0

WARNING: Block comments should align the * on each line
#1175: FILE: arch/riscv/include/asm/dovetail.h:2:
+/*
+* SPDX-License-Identifier: GPL-2.0

Any reasons why you didn't address all those further warnings?

Btw: Line numbers above relate to a one-series mailbox file compiled by
b4: 

b4 am <your-message-id-from-the-list>
scripts/checkpatch <generated.mbox>

> 
> > > +			if (syscall == EXIT_SYSCALL_OOB) {
> > > +				hard_local_irq_disable();
> > > +				return;
> > > +			}
> > > +			if (syscall == EXIT_SYSCALL_TAIL)
> > > +				goto done_inband;
> > > +		}
> > > +