Re: [cocci] [PATCH 1/3] PM: runtime: Stop checking pm_runtime_barrier() return code

On Wed, Dec 3, 2025 at 4:34 AM Guenter Roeck <[email protected]> wrote:
>
> On Tue, Dec 02, 2025 at 11:30:24AM -0800, Brian Norris wrote:
> > Apparently this test is the only code that checks the return code from
> > pm_runtime_barrier(), and it turns out that's for good reason -- it's
> > inherently racy, and a bad idea. We're going to make
> > pm_runtime_barrier() return void, so prepare for that by dropping any
> > return code checks.
> >
> > This resolves some test failures seen like the following:
> >
> > [   34.559694]     # pm_runtime_error_test: EXPECTATION FAILED at drivers/base/power/runtime-test.c:177
> > [   34.559694]     Expected 1 == pm_runtime_barrier(dev), but
> > [   34.559694]         pm_runtime_barrier(dev) == 0 (0x0)
> > [   34.563604]     # pm_runtime_error_test: pass:0 fail:1 skip:0 total:1
> >
> > Reported-by: Guenter Roeck <[email protected]>
> > Closes: https://lore.kernel.org/lkml/[email protected]/
> > Signed-off-by: Brian Norris <[email protected]>
>
> With this series on top of v6.18:
>
> Qemu test results:
>         total: 610 pass: 610 fail: 0
> Unit test results:
>         pass: 666898 fail: 0
>
> Tested-by: Guenter Roeck <[email protected]>

Applied along with the [2-3/3] as 6.19-rc material, thanks!