Re: [cocci] [PATCH v2] iommu: simplify list initialization in iommu_create_device_direct_mappings() and iommu_group_show_resv_regions()
Vasant Hegde <[email protected]> Tue, 13 Jan 2026 15:34:57 +0530
| Newsgroups | fr.inria.cocci,dev.linux.lists.iommu,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 1/12/2026 6:00 PM, Markus Elfring wrote: >> Changes since v1: >> - Extend the cleanup to iommu_group_show_resv_regions() as suggested by >> reviewer, applying the same LIST_HEAD() pattern consistently across >> the file. > > Thanks for your interest in further code adjustments. > > * I wonder how they fit to the feedback “Applied, thanks.” by Jörg Rödel > from 2026-01-10. > https://lore.kernel.org/lkml/stpavkxy3sbevk7zmt4kxyecqy5gc6phubvcfutbtnuk7vphlh@a7aimtvk423i/ > https://lkml.org/lkml/2026/1/10/235 Right. Patch is already applied. @Can, Please rebase patch on top of iommu/next branch. > > * A shorter summary phrase might become more desirable for this patch variant. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc4#n687 > > * Will development interests grow also for another transformation approach > like the following by the means of the semantic patch language (Coccinelle software)? > > > @replacement@ > expression e; > identifier i; > @@ > -struct list_head i; > ... when exists > when != i = e > -INIT_LIST_HEAD > +LIST_HEAD > ( > - & > i > ); > > > I determined that 175 source files of the software “Linux next-20260109” contain > corresponding update candidates. Interesting! Thanks for the stat. -Vasant