Re: [cocci] [RFC] Coccinelle: Use IS_ERR_OR_NULL

Markus Elfring <[email protected]> Fri, 6 Mar 2026 09:26:17 +0100

Newsgroups	fr.inria.cocci
Message-ID	<[email protected]>

…
> +@p1 depends on patch@
> +expression E;
> +@@
> +(
> +-	E != NULL && !IS_ERR(E)
> ++	!IS_ERR_OR_NULL(E)
> +|
> +-	E == NULL || IS_ERR(E)
> ++	!IS_ERR_OR_NULL(E)
> +|
> +-	!IS_ERR(E) && E != NULL
> ++	IS_ERR_OR_NULL(E)
> +|
> +-	IS_ERR(E) || E == NULL
> ++	IS_ERR_OR_NULL(E)
> +)
…

Did you get confused with the negation of any code items?

Would you get further development ideas from an SmPL code variant
like the following?

@replacements@
expression e;
@@
(
-IS_ERR(e) || e == NULL
+IS_ERR_OR_NULL(e)
|
-e == NULL || IS_ERR(e)
+IS_ERR_OR_NULL(e)
|
-!IS_ERR(e) && e != NULL
+!IS_ERR_OR_NULL(e)
|
-e != NULL && !IS_ERR(e)
+!IS_ERR_OR_NULL(e)
)


Regards,
Markus