Re: [cocci] [PATCH 03/61] ceph: Prefer IS_ERR_OR_NULL over manual NULL check
Viacheslav Dubeyko <[email protected]> Tue, 10 Mar 2026 18:13:03 +0000
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2026-03-10 at 12:48 +0100, Philipp Hahn wrote: > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Ilya Dryomov <[email protected]> > To: Alex Markuze <[email protected]> > To: Viacheslav Dubeyko <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> > --- > fs/ceph/dir.c | 2 +- > fs/ceph/snap.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > index 86d7aa594ea99335af3e91a95c0a418fdc1b8a8a..934250748ae4fd4c148fd27bdf91175047c2877d 100644 > --- a/fs/ceph/dir.c > +++ b/fs/ceph/dir.c > @@ -889,7 +889,7 @@ int ceph_handle_notrace_create(struct inode *dir, struct dentry *dentry) > { > struct dentry *result = ceph_lookup(dir, dentry, 0); > > - if (result && !IS_ERR(result)) { > + if (!IS_ERR_OR_NULL(result)) { > /* > * We created the item, then did a lookup, and found > * it was already linked to another inode we already > diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c > index 52b4c2684f922bfed39550311e793bfe3622cd26..528ad581be160713f91416115659e2dc6f259576 100644 > --- a/fs/ceph/snap.c > +++ b/fs/ceph/snap.c > @@ -902,7 +902,7 @@ int ceph_update_snap_trace(struct ceph_mds_client *mdsc, > bad: > err = -EIO; > fail: > - if (realm && !IS_ERR(realm)) > + if (!IS_ERR_OR_NULL(realm)) > ceph_put_snap_realm(mdsc, realm); > if (first_realm) > ceph_put_snap_realm(mdsc, first_realm); Looks good. Reviewed-by: Viacheslav Dubeyko <[email protected]> Thanks, Slava.