RE: [cocci] [Intel-wired-lan] [PATCH 39/61] irqchip: Prefer IS_ERR_OR_NULL over manual NULL check
"Loktionov, Aleksandr" <[email protected]> Wed, 11 Mar 2026 09:24:44 +0000
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <IA3PR11MB898641F143E155B8A8069936E547A@IA3PR11MB8986.namprd11.prod.outlook.com> |
> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf > Of Philipp Hahn > Sent: Tuesday, March 10, 2026 12:49 PM > To: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; dm- > [email protected]; [email protected]; > [email protected]; [email protected]; intel-wired- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux-security- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; sched- > [email protected]; [email protected]; tipc- > [email protected]; [email protected]; Philipp Hahn > <[email protected]> > Cc: Marc Zyngier <[email protected]>; Thomas Gleixner <[email protected]>; > Andrew Lunn <[email protected]>; Gregory Clement > <[email protected]>; Sebastian Hesselbarth > <[email protected]> > Subject: [Intel-wired-lan] [PATCH 39/61] irqchip: Prefer > IS_ERR_OR_NULL over manual NULL check > > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Marc Zyngier <[email protected]> > To: Thomas Gleixner <[email protected]> > To: Andrew Lunn <[email protected]> > To: Gregory Clement <[email protected]> > To: Sebastian Hesselbarth <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> > --- > drivers/irqchip/irq-gic-v3.c | 2 +- > drivers/irqchip/irq-mvebu-odmi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic- > v3.c index > 20f13b686ab22faf722dd2b24faf96af636a4bbd..6dc9827357a21ae05dd838fb7178 > 71c73f3c7562 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -2252,7 +2252,7 @@ static int __init gic_of_init(struct device_node > *node, struct device_node *pare > > out_unmap_rdist: > for (i = 0; i < nr_redist_regions; i++) > - if (rdist_regs[i].redist_base && > !IS_ERR(rdist_regs[i].redist_base)) > + if (!IS_ERR_OR_NULL(rdist_regs[i].redist_base)) > iounmap(rdist_regs[i].redist_base); > kfree(rdist_regs); > out_unmap_dist: > diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq- > mvebu-odmi.c > index > b99ab9dcc14b3ba982876cf5525499d02bc1c997..94e7eda46e81833cfe0479b6fabb > a715bf4ef6b8 100644 > --- a/drivers/irqchip/irq-mvebu-odmi.c > +++ b/drivers/irqchip/irq-mvebu-odmi.c > @@ -217,7 +217,7 @@ static int __init mvebu_odmi_init(struct > device_node *node, > for (i = 0; i < odmis_count; i++) { > struct odmi_data *odmi = &odmis[i]; > > - if (odmi->base && !IS_ERR(odmi->base)) > + if (!IS_ERR_OR_NULL(odmi->base)) > iounmap(odmis[i].base); > } > bitmap_free(odmis_bm); > > -- > 2.43.0 Reviewed-by: Aleksandr Loktionov <[email protected]>