Re: [cocci] Searching inappropriate readl specifications with SmPL?

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-280001916-1780863971=:56433
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT



On Sun, 7 Jun 2026, Markus Elfring wrote:

> Hello,
>
> Felix Gu pointed another software correction out.
>
> I assumed that something can be achieved also by the means of the semantic
> patch language accordingly.
>
>
> // See also:
> // [PATCH] spi: rzv2h-rspi: fix incorrect readl() accessor for 8-bit RX path
> // https://lore.kernel.org/linux-spi/[email protected]/
>
> // https://elixir.bootlin.com/linux/v7.1-rc6/source/drivers/spi/spi-rzv2h-rspi.c#L140
> @display@
> identifier action;
> typedef u8;
> @@
> *action(readl, u8)
>
>
> Questionable test result (in combination with the software “Coccinelle 1.3.1”):
> Markus_Elfring@Sonne:…/Projekte/Linux/next-analyses> time /usr/bin/spatch …/Projekte/Coccinelle/janitor/show_questionable_readl.cocci drivers/spi/spi-rzv2h-rspi.c

Please include a complete example with a semantic patch and a minimal
extract oc C code in which you think the result is not correct.

Maybe Coccinelle was not able to parse the code thta contains what you are
searhing for?

julia

> …
> real    0m0,119s
> user    0m0,103s
> sys     0m0,014s
>
>
> Why is an expected difference display not generated so far?
>
> Regards,
> Markus
>
--8323329-280001916-1780863971=:56433--