Re: [cocci] Searching for duplicate exception handling code with SmPL?
Julia Lawall <[email protected]> Mon, 15 Jun 2026 17:20:57 +0200 (CEST)
| Newsgroups | fr.inria.cocci |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 15 Jun 2026, Markus Elfring wrote: > >> I am trying to determine once more how plausible the mentioned data processing results are. > > It would be better to look at them yourself. > > I started to take another look at a few of the mentioned function implementations. > > > Examples: > info|arch_xen_unpopulated_init|regs|rc > first|./arch/arm/xen/enlighten.c|410|2 > tail|./arch/arm/xen/enlighten.c|410|2 > > https://elixir.bootlin.com/linux/v7.1-rc7/source/arch/arm/xen/enlighten.c#L307-L413 > False positive I already explained how to solve this problem. You should forbid a goto before at least one of the kfrees. You may need two rules to forbid a goto before each one. julia > > > > info|kvm_eiointc_create|s|ret > first|./arch/loongarch/kvm/intc/eiointc.c|642|3 > tail|./arch/loongarch/kvm/intc/eiointc.c|656|3 > > https://elixir.bootlin.com/linux/v7.1-rc7/source/arch/loongarch/kvm/intc/eiointc.c#L614-L658 > Appropriate update candidate > > > > info|device_str_attr_create|s|NULL > first|./arch/powerpc/perf/hv-24x7.c|506|2 > tail|./arch/powerpc/perf/hv-24x7.c|506|2 > > https://elixir.bootlin.com/linux/v7.1-rc7/source/arch/powerpc/perf/hv-24x7.c#L470-L507 > Questionable > > > Regards, > Markus >