Re: [PATCH] ARM: dts: Kill off skeleton{64}.dtsi

Linus Walleij <[email protected]> Fri, 30 Nov 2018 18:21:35 +0100
Newsgroups io.groups.linux-oxnas,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree
Message-ID <CACRpkdaxAX72a6vpOqGwhhPEKeCz3YJz3wjxF5nsRmei-cRY8w@mail.gmail.com>
On Fri, Nov 30, 2018 at 6:06 PM Rob Herring <[email protected]> wrote:

> Remove the usage of skeleton.dtsi in the remaining dts files. It was
> deprecated since commit 9c0da3cc61f1 ("ARM: dts: explicitly mark
> skeleton.dtsi as deprecated"). This will make adding a unit-address to
> memory nodes easier.
>
> The main tricky part to removing skeleton.dtsi is we could end up with
> no /memory node at all when a bootloader depends on one being present. I
> hacked up dtc to check for this condition.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Linus Walleij <[email protected]>
Good riddance.

> Yes, I'm being lazy and not splitting this up into dozens of sub-arch
> patches. I don't think this should conflict nor should we be getting new
> dependencies on skeleton.dtsi. So please apply directly to arm-soc.

A patch should be "one technical step" and this is one technical step.

I don't think the compulsive requests to split patches up gives
us anything in cases like this, it just cost us valuable development
time.

So this is the right approach.

Linus Walleij