Re: [PATCH] mtd: nand: Convert to platform remove callback returning void
Tudor Ambarus <[email protected]> Mon, 10 Apr 2023 06:37:11 +0100
| Newsgroups | io.groups.linux-oxnas,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.infradead.lists.linux-mtd,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <[email protected]> |
On 4/8/23 19:53, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Acked-by: Nicolas Ferre <[email protected]> > Reviewed-by: Paul Cercueil <[email protected]> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > Acked-by: Martin Blumenstingl <[email protected]> > Reviewed-by: Martin Blumenstingl <[email protected]> > Acked-by: Roger Quadros <[email protected]> > Reviewed-by: Geert Uytterhoeven <[email protected]> > Reviewed-by: Heiko Stuebner <[email protected]> > Acked-by: Jernej Skrabec <[email protected]> > Acked-by: Thierry Reding <[email protected]> > Signed-off-by: Uwe Kleine-König <[email protected]> b4 seems didn't take my tag on 00/49, here it is again: Acked-by: Tudor Ambarus <[email protected]>