Re: [PATCH net-next v2 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
Martin Blumenstingl <[email protected]> Mon, 8 May 2023 21:38:41 +0200
| Newsgroups | io.groups.linux-oxnas,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.kernel.vger.netdev |
|---|---|
| Message-ID | <CAFBinCAXQywWReBbqRCgB36gKGjhX9Tx6g-8OTewt_xipdhp3w@mail.gmail.com> |
On Mon, May 8, 2023 at 4:27=E2=80=AFPM Uwe Kleine-K=C3=B6nig <[email protected]> wrote: > > The function returns zero unconditionally. Change it to return void inste= ad > which simplifies some callers as error handing becomes unnecessary. > > The function is also used for some drivers as remove callback. Switch the= se > to the .remove_new() callback. For some others no error can happen in the > remove callback now, convert them to .remove_new(), too. > > Acked-by: Jernej Skrabec <[email protected]> > Reviewed-by: Simon Horman <[email protected]> > Acked-by: Martin Blumenstingl <[email protected]> > Signed-off-by: Uwe Kleine-K=C3=B6nig <[email protected]> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 9 +++------ > drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 9 +++------ > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- For these two Amlogic Meson drivers: Reviewed-by: Martin Blumenstingl <[email protected]>