Re: [PATCH -next 15/30] pinctrl: oxnas: use devm_platform_ioremap_resource() to simplify code
"Neil Armstrong" <[email protected]> Thu, 17 Oct 2019 14:50:11 +0200
| Newsgroups | io.groups.linux-oxnas,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <[email protected]> |
On 17/10/2019 14:26, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <[email protected]> > --- > drivers/pinctrl/pinctrl-oxnas.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-oxnas.c b/drivers/pinctrl/pinctrl-oxnas.c > index 40dc125..674b7b5 100644 > --- a/drivers/pinctrl/pinctrl-oxnas.c > +++ b/drivers/pinctrl/pinctrl-oxnas.c > @@ -1196,7 +1196,6 @@ static int oxnas_gpio_probe(struct platform_device *pdev) > struct oxnas_gpio_bank *bank; > unsigned int id, ngpios; > int irq, ret; > - struct resource *res; > struct gpio_irq_chip *girq; > > if (of_parse_phandle_with_fixed_args(np, "gpio-ranges", > @@ -1220,8 +1219,7 @@ static int oxnas_gpio_probe(struct platform_device *pdev) > > bank = &oxnas_gpio_banks[id]; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - bank->reg_base = devm_ioremap_resource(&pdev->dev, res); > + bank->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(bank->reg_base)) > return PTR_ERR(bank->reg_base); > > Acked-by: Neil Armstrong <[email protected]>