Re: [PATCH] irqchip/versatile-fpga: Apply clear-mask earlier

Linus Walleij <[email protected]> Sun, 22 Mar 2020 12:45:29 +0100

Newsgroups	io.groups.linux-oxnas,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID	<CACRpkdYvoVF_q1Re_v_sJCYVDOhte0NpdU91UtYB2SpHH60-jg@mail.gmail.com>

On Sat, Mar 21, 2020 at 2:40 PM Sungbo Eo <[email protected]> wrote:

> Clear its own IRQs before the parent IRQ get enabled, so that the
> remaining IRQs do not accidentally interrupt the parent IRQ controller.
>
> This patch also fixes a reboot bug on OX820 SoC, where the remaining
> rps-timer IRQ raises a GIC interrupt that is left pending. After that,
> the rps-timer IRQ is cleared during driver initialization, and there's
> no IRQ left in rps-irq when local_irq_enable() is called, which evokes
> an error message "unexpected IRQ trap".
>
> Fixes: bdd272cbb97a ("irqchip: versatile FPGA: support cascaded interrupts from DT")
> Signed-off-by: Sungbo Eo <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Daniel Golle <[email protected]>

Good catch!
Reviewed-by: Linus Walleij <[email protected]>

Marc: Cc stable?

Yours,
Linus Walleij