Re: [PATCH] ARM: oxnas: make ox820_boot_secondary static

On 12/05/2020 03:46, Ma Feng wrote:
> Fix sparse warning:
> 
> arch/arm/mach-oxnas/platsmp.c:30:12: warning: symbol 'ox820_boot_secondary' was
> not declared. Should it be static?
> 
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Ma Feng <[email protected]>
> ---
>  arch/arm/mach-oxnas/platsmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c
> index ab35275..f0a50b9 100644
> --- a/arch/arm/mach-oxnas/platsmp.c
> +++ b/arch/arm/mach-oxnas/platsmp.c
> @@ -27,7 +27,8 @@ static void __iomem *gic_cpu_ctrl;
>  #define GIC_CPU_CTRL			0x00
>  #define GIC_CPU_CTRL_ENABLE		1
> 
> -int __init ox820_boot_secondary(unsigned int cpu, struct task_struct *idle)
> +static int __init ox820_boot_secondary(unsigned int cpu,
> +		struct task_struct *idle)
>  {
>  	/*
>  	 * Write the address of secondary startup into the
> --
> 2.7.4
> 

Acked-by: Neil Armstrong <[email protected]>