Re: [PATCH RFC 26/26] dts: support building all dtb files for a specific vendor

Tom Rini <[email protected]> Tue, 5 Mar 2024 07:42:50 -0500

Newsgroups	io.groups.u-boot-amlogic,org.u-boot-project.lists.u-boot
Message-ID	<20240305124250.GZ1523872@bill-the-cat>

On Tue, Mar 05, 2024 at 06:05:52PM +0530, Sumit Garg wrote:
> Hi Caleb,
> 
> On Mon, 4 Mar 2024 at 22:22, Caleb Connolly <[email protected]> wrote:
> >
> > This adjusts OF_UPSTREAM to behave more like the kernel by allowing for
> > all the devicetree files for a given vendor to be compiled. This is
> > useful for Qualcomm in particular as most boards are supported by a
> > single U-Boot build just provided with a different DT.
> >
> > Signed-off-by: Caleb Connolly <[email protected]>
> > ---
> >  dts/Kconfig          | 24 ++++++++++++++++++++++++
> >  scripts/Makefile.dts | 17 ++++++++++++++++-
> >  2 files changed, 40 insertions(+), 1 deletion(-)
> >
> > diff --git a/dts/Kconfig b/dts/Kconfig
> > index b9b6367154ef..67d9dc489856 100644
> > --- a/dts/Kconfig
> > +++ b/dts/Kconfig
> > @@ -100,8 +100,32 @@ config OF_UPSTREAM
> >           However, newer boards whose devicetree source files haven't landed in
> >           the dts/upstream subtree, they can override this option to have the
> >           DT build from existing U-Boot tree location instead.
> >
> > +config OF_UPSTREAM_BUILD_VENDOR
> > +       bool "Build all devicetree files for a particular vendor"
> > +       depends on OF_UPSTREAM
> > +       help
> > +         Enable building all devicetree files for a particular vendor. This
> 
> Do we really want to build all the DTBs even if many of those aren't
> supported by U-Boot at all? I would have rather added Makefile targets
> for boards which really supports a single defconfig eg.
> qcom_defconfig.

Yes, I think this target is useful as it addresses some of Simon's
earlier concerns with the feature.

-- 
Tom

signature.asc (application/pgp-signature, 659 B)