Re: [PATCH v5 0/6] android_ab: introduce bcb ab_dump command and provide several bcb fixes

Hi Dmitry,

Thank you for this series.

On jeu., oct. 17, 2024 at 17:12, Dmitry Rokosov <[email protected]> wrote:

> The patch series include changes:
>     - move ab_select_slot() documentation to @ notation
>     - redesign 'bcb' command to U_BOOT_LONGHELP approach
>     - move ab_select command to bcb subcommands
>     - introduce the ab_dump command to print the content of the BCB
>       block; it's useful for debugging A/B logic on supported boards
>     - fix the slot suffix format in the ABC block to align with official
>       Android BCB specifications
>     - add a test for the ab_dump command to verify the accuracy of each
>       field within the ABC data displayed, it's also useful for testing
>       slot_suffix problem code paths
>
> Signed-off-by: Dmitry Rokosov <[email protected]>

Boot tested AOSP using on Khadas VIM3 using khadas_vim3_android_defconfig

Tested-by: Mattijs Korpershoek <[email protected]> # vim3_android

Boot tested Android 14 on Beagle Play using:
am62x_beagleplay_a53_defconfig and am62x_a53_android.config

Tested-by: Mattijs Korpershoek <[email protected]> # beagleplay

> ---
> Changes in v5:
> - rework direct #ifdefs to IS_ENABLED() macro
> - redesign 'bcb' command to U_BOOT_LONGHELP approach
> - check argc directly in the ab_select and ab_dump subcommands handlers
> - Link to v4: https://lore.kernel.org/r/[email protected]
>
> Changes in v4:
> - add #ifdefs for CONFIG_ANDROID_AB in cmd/bcb.c to allow the usage of
>   the bcb command without A/B enabled
> - run the savedefconfig command for all defconfigs that include the
>   CMD_BCB configuration
> - resolve merge conflicts with latest master
> - provide additional trailers from the previous version (excluding
>   changed patches)
> - Link to v3: https://lore.kernel.org/r/[email protected]
>
> Changes in v3:
> - return "Legend" block for bcb command
> - additionally, verify the CONFIG_ANDROID_AB configuration alongside
>   CONFIG_CMD_BCB to ensure that the A/B scheme is used for the
>   designated board.
> - Link to v2: https://lore.kernel.org/all/[email protected]/
>
> Changes in v2:
> - move ab_select_slot() documentation to @ notation
> - move ab_select command to bcb subcommands per Simon and Mattijs
>   suggestions
> - redesign ab_dump as bcb subcommand
> - use spaces instead of tabs in the ab_dump command output
> - print hex values in the lowercase
> - add RvB tags
> - Link to v1: https://lore.kernel.org/all/[email protected]/
>
> ---
> Dmitry Rokosov (6):
>       include/android_ab: move ab_select_slot() documentation to @ notation
>       cmd: bcb: rework the command to U_BOOT_LONGHELP approach
>       treewide: bcb: move ab_select command to bcb subcommands
>       cmd: bcb: change strcmp() usage style in the do_bcb_ab_select()
>       cmd: bcb: introduce 'ab_dump' command to print BCB block content
>       common: android_ab: fix slot suffix for abc block
>
>  MAINTAINERS                               |   1 -
>  boot/android_ab.c                         | 116 +++++++++++++---
>  cmd/Kconfig                               |  14 --
>  cmd/Makefile                              |   1 -
>  cmd/ab_select.c                           |  66 ---------
>  cmd/bcb.c                                 | 221 +++++++++++++++++-------------
>  configs/am57xx_evm_defconfig              |   1 -
>  configs/am57xx_hs_evm_defconfig           |   1 -
>  configs/am57xx_hs_evm_usb_defconfig       |   1 -
>  configs/khadas-vim3_android_ab_defconfig  |   1 -
>  configs/khadas-vim3l_android_ab_defconfig |   1 -
>  configs/sandbox64_defconfig               |   2 +
>  configs/sandbox_defconfig                 |   1 -
>  doc/android/ab.rst                        |  12 +-
>  include/android_ab.h                      |  17 ++-
>  include/configs/khadas-vim3_android.h     |   2 +-
>  include/configs/khadas-vim3l_android.h    |   2 +-
>  include/configs/meson64_android.h         |   4 +-
>  include/configs/ti_omap5_common.h         |   4 +-
>  test/py/tests/test_android/test_ab.py     |  31 ++++-
>  20 files changed, 275 insertions(+), 224 deletions(-)
> ---
> base-commit: 98a36deb9ab7aaea70b0b0db47718100e08cf3e8
> change-id: 20241008-android_ab_master-d86d71c839ae
>
> Best regards,
> -- 
> Dmitry Rokosov <[email protected]>