Re: [RFC v1 1/7] usb: onboard-hub: Add support for Genesys GL852G hub

On 09/05/2025 09:02, Anand Moon wrote:
> Add support for the Genesys GL852G USB2.0 Hub on Odroid C1+
> and Odroid C2. The GL852G driver trigger hub reset signal
> which toggles the gpio.
> 
> Signed-off-by: Anand Moon <[email protected]>
> ---
> Still some issue with USB hub on Odroid C2

What does that mean ?

> => dm tree
> 
>   vidconsole    0  [ + ]   vidconsole0           |   |   `-- [email protected]
>   display       0  [   ]   meson_dw_hdmi         |   |-- hdmi-tx@c883a000
>   phy           0  [ + ]   meson_gxbb_usb2_phy   |   |-- phy@c0000020
>   usb           0  [ + ]   dwc2_usb              |   `-- usb@c9100000
>   usb_hub       0  [ + ]   usb_hub               |       `-- usb_hub
>   usb_hub       1  [ + ]   usb_hub               |           `-- usb_hub
>   regulator     0  [ + ]   regulator_fixed       |-- regulator-usb-pwrs
> ---
>   common/usb_onboard_hub.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/common/usb_onboard_hub.c b/common/usb_onboard_hub.c
> index 7fe62b043e6..39bbc1aefa2 100644
> --- a/common/usb_onboard_hub.c
> +++ b/common/usb_onboard_hub.c
> @@ -227,6 +227,10 @@ static const struct onboard_hub_data usb5744_data = {
>   	.reset_us = 5,
>   };
>   
> +static const struct onboard_hub_data genesys_gl852g_data = {
> +	.reset_us = 50,
> +};
> +
>   static const struct udevice_id usb_onboard_hub_ids[] = {
>   	/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
>   	{	.compatible = "usb424,2514",	/* USB2514B USB 2.0 */
> @@ -237,6 +241,9 @@ static const struct udevice_id usb_onboard_hub_ids[] = {
>   	}, {
>   		.compatible = "usb424,5744",	/* USB5744 USB 3.0 */
>   		.data = (ulong)&usb5744_data,
> +	}, {
> +		.compatible = "usb5e3,610",     /* GL852G USB 2.0 */
> +		.data = (ulong)&genesys_gl852g_data,
>   	}
>   };
>