Re: [RFC v1 3/7] usb: onboard-hub: Add support for Genesys GL853G

On 09/05/2025 09:02, Anand Moon wrote:
> Enable support for the Genesys GL853G USB2.0 and USB3.1 Hub on
> the Odroid N2 and N2-plus. The GL853G driver activates the hub
> reset signal, which toggles the GPIO.
> 
> Signed-off-by: Anand Moon <[email protected]>
> ---
> => dm tree
> 
>   simple_bus   11  [ + ]   dwc3-meson-g12a       |   `-- usb@ffe09000
>   usb_gadget    0  [   ]   dwc2-udc-otg          |       |-- usb@ff400000
>   usb           0  [ + ]   xhci-dwc3             |       `-- usb@ff500000
>   usb_hub       0  [ + ]   usb_hub               |           `-- usb_hub
>   usb_hub       1  [ + ]   usb_hub               |               |-- usb_hub
>   usb_mass_s    0  [ + ]   usb_mass_storage      |               |   `-- usb_mass_storage
>   blk           2  [ + ]   usb_storage_blk       |               |       |-- usb_mass_storage.lun0
>   partition     0  [ + ]   blk_partition         |               |       |   `-- usb_mass_storage.lun0:1
>   bootdev       3  [   ]   usb_bootdev           |               |       `-- usb_mass_storage.lun0.bootdev
>   usb_hub       2  [ + ]   usb_hub               |               `-- usb_hub
>   clk           2  [ + ]   fixed_clock           |-- xtal-clk
> ---
>   common/usb_onboard_hub.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/common/usb_onboard_hub.c b/common/usb_onboard_hub.c
> index 39bbc1aefa2..3914e2f773d 100644
> --- a/common/usb_onboard_hub.c
> +++ b/common/usb_onboard_hub.c
> @@ -231,6 +231,10 @@ static const struct onboard_hub_data genesys_gl852g_data = {
>   	.reset_us = 50,
>   };
>   
> +static const struct onboard_hub_data genesys_gl853g_data = {
> +	.reset_us = 50,
> +};
> +
>   static const struct udevice_id usb_onboard_hub_ids[] = {
>   	/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
>   	{	.compatible = "usb424,2514",	/* USB2514B USB 2.0 */
> @@ -244,6 +248,9 @@ static const struct udevice_id usb_onboard_hub_ids[] = {
>   	}, {
>   		.compatible = "usb5e3,610",     /* GL852G USB 2.0 */
>   		.data = (ulong)&genesys_gl852g_data,
> +	}, {
> +		.compatible = "usb5e3,620",     /* GL852G USB 3.1 */
> +		.data = (ulong)&genesys_gl853g_data,
>   	}
>   };
>   

Reviewed-by: Neil Armstrong <[email protected]>