Re: [PATCH] clk: meson: Remove unreachable code

On 23/07/2025 18:37, Andrew Goodbody wrote:
> A second return following the first return is unreachable code so remove
> it.
> 
> This issue was found by Smatch.
> 
> Signed-off-by: Andrew Goodbody <[email protected]>
> ---
>   drivers/clk/meson/g12a.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 5d7faaa3eab..a7a42b2edb6 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -916,8 +916,6 @@ static ulong meson_clk_set_rate_by_id(struct clk *clk, unsigned long id,
>   			return -EINVAL;
>   	case CLKID_PCIE_PLL:
>   		return meson_pcie_pll_set_rate(clk, rate);
> -
> -		return 0;
>   	case CLKID_VPU:
>   		return meson_clk_set_rate_by_id(clk,
>   				meson_mux_get_parent(clk, CLKID_VPU), rate,
> 
> ---
> base-commit: bd0ade7d090a334b3986936d63a34001d99722ad
> change-id: 20250723-clk_meson-3d90bc29f8dc
> 
> Best regards,

Reviewed-by: Neil Armstrong <[email protected]>