Re: [PATCH 23/24] clk: stm32: Remove negative error returns from clk_get_rate

On 10/15/25 16:32, Andrew Goodbody wrote:
> clk_get_rate() returns a ulong so do not attempt to pass negative error
> codes through it.
> 
> Signed-off-by: Andrew Goodbody <[email protected]>
> ---
>  drivers/clk/stm32/clk-stm32-core.c | 4 ++--
>  drivers/clk/stm32/clk-stm32f.c     | 6 +++---
>  drivers/clk/stm32/clk-stm32h7.c    | 4 ++--
>  3 files changed, 7 insertions(+), 7 deletions(-)


Reviewed-by: Patrice Chotard <[email protected]>

Thanks
Patrice

> 
> diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c
> index 858f122db1a6db02eadc110a7b3e14192654d8ff..5220d49d4206808734f9838d3e55298cf6b163ab 100644
> --- a/drivers/clk/stm32/clk-stm32-core.c
> +++ b/drivers/clk/stm32/clk-stm32-core.c
> @@ -106,11 +106,11 @@ static ulong stm32_clk_get_rate(struct clk *clk)
>  	struct clk *c = NULL;
>  
>  	if (!clk->id || clk_get_by_id(clk->id, &c))
> -		return -ENOENT;
> +		return 0;
>  
>  	ops = clk_dev_ops(c->dev);
>  	if (!ops->get_rate)
> -		return -ENOSYS;
> +		return 0;
>  
>  	return ops->get_rate(c);
>  }
> diff --git a/drivers/clk/stm32/clk-stm32f.c b/drivers/clk/stm32/clk-stm32f.c
> index fceb3c44b94e4e4f5249ff1bc99c7ae4adba4316..db64139d13d4b3fff74838d9e14ae6c5e61c7941 100644
> --- a/drivers/clk/stm32/clk-stm32f.c
> +++ b/drivers/clk/stm32/clk-stm32f.c
> @@ -310,7 +310,7 @@ static unsigned long stm32_clk_get_pllsai_rate(struct stm32_clk *priv,
>  		break;
>  	default:
>  		log_err("incorrect PLLSAI output %d\n", output);
> -		return -EINVAL;
> +		return 0;
>  	}
>  
>  	return (stm32_clk_get_pllsai_vco_rate(priv) / pll_div_output);
> @@ -414,7 +414,7 @@ static ulong stm32_clk_get_rate(struct clk *clk)
>  		vco = (priv->hse_rate / pllm) * plln;
>  		sysclk = vco / pllp;
>  	} else {
> -		return -EINVAL;
> +		return 0;
>  	}
>  
>  	switch (clk->id) {
> @@ -491,7 +491,7 @@ static ulong stm32_clk_get_rate(struct clk *clk)
>  
>  	default:
>  		dev_err(clk->dev, "clock index %ld out of range\n", clk->id);
> -		return -EINVAL;
> +		return 0;
>  	}
>  }
>  
> diff --git a/drivers/clk/stm32/clk-stm32h7.c b/drivers/clk/stm32/clk-stm32h7.c
> index df82db69738a5d9704592d5cdbec52125c0620a1..eb8fb72976b60c8016408693631470a0e369e8cb 100644
> --- a/drivers/clk/stm32/clk-stm32h7.c
> +++ b/drivers/clk/stm32/clk-stm32h7.c
> @@ -573,7 +573,7 @@ static u32 stm32_get_PLL1_rate(struct stm32_rcc_regs *regs,
>  		break;
>  	}
>  
> -	return -EINVAL;
> +	return 0;
>  }
>  
>  static u32 stm32_get_apb_psc(struct stm32_rcc_regs *regs, enum apb apb)
> @@ -780,7 +780,7 @@ static ulong stm32_clk_get_rate(struct clk *clk)
>  	default:
>  		dev_err(clk->dev, "unexpected gate_offset value (0x%x)\n",
>  			gate_offset);
> -		return -EINVAL;
> +		return 0;
>  		break;
>  	}
>  }
>