Re: [PATCH] tools: amlimage: include <inttypes.h>

Ferass El Hafidi <[email protected]> Tue, 13 Jan 2026 18:12:49 +0000
Newsgroups io.groups.u-boot-amlogic,org.u-boot-project.lists.u-boot
Message-ID <[email protected]>
On Tue, 13 Jan 2026 11:07, Robert Marko <[email protected]> wrote:
>PRIuN, PRIxN, etc macros are defined in <inttypes.h>, without it being
>included errors like:
>tools/amlimage.c:124:38: error: expected ‘)’ before ‘PRIu8’
>tools/amlimage.c:126:31: error: expected ‘)’ before ‘PRIu32’
>
>Can be hit depending on the host compiler and HOSTCFLAGS.
>
>Fixes: 18c1654567dc ("tools: mkimage: Add Amlogic Boot Image type")
>Signed-off-by: Robert Marko <[email protected]>
>---
> tools/amlimage.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/amlimage.c b/tools/amlimage.c
>index ecb06bc535b..bc6e19b9c24 100644
>--- a/tools/amlimage.c
>+++ b/tools/amlimage.c
>@@ -2,6 +2,7 @@
> // Copyright Contributors to the U-Boot project.
> 
> #include "imagetool.h"
>+#include <inttypes.h>
> #include <u-boot/sha256.h>
> 
> /*
>-- 
>2.52.0
>

Looks good to me, thanks!

Reviewed-by: Ferass El Hafidi <[email protected]>

Best regards,
Ferass