Re: [PATCH 34/36] ufs: qcom: use clk_prepare_enable_bulk()

Neil Armstrong <[email protected]> Tue, 21 Jul 2026 09:26:49 +0200
Newsgroups io.groups.u-boot-amlogic
Organization Linaro
Message-ID <[email protected]>
On 7/20/26 18:41, Casey Connolly wrote:
> With CCF the clocks have to be prepared before enabling. The CCF core
> will do this for us but it's much better to be explicit.
> 
> Signed-off-by: Casey Connolly <[email protected]>
> ---
>   drivers/ufs/ufs-qcom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/ufs-qcom.c b/drivers/ufs/ufs-qcom.c
> index f5f5a6eb110c..3656c3861cb5 100644
> --- a/drivers/ufs/ufs-qcom.c
> +++ b/drivers/ufs/ufs-qcom.c
> @@ -38,9 +38,9 @@ static int ufs_qcom_enable_clks(struct ufs_qcom_priv *priv)
>   
>   	if (priv->is_clks_enabled)
>   		return 0;
>   
> -	err = clk_enable_bulk(&priv->clks);
> +	err = clk_prepare_enable_bulk(&priv->clks);
>   	if (err)
>   		return err;
>   
>   	priv->is_clks_enabled = true;
> 

Reviewed-by: Neil Armstrong <[email protected]>

Thanks,
Neil