Re: [LTP] fanotify20: Skip FAN_REPORT_PIDFD | FAN_REPORT_TID test on v7.2+

Hi AnonymeMeow,


> --- [PATCH 1/5] ---
> 
> > +	if (tst_kvercmp(7, 2, 0) >= 0)
> > +		tst_brk(TCONF, "FAN_REPORT_PIDFD | FAN_REPORT_TID is supported "
> > +			       "since v7.2, skipping test");
> 
> tst_brk(TCONF) in setup aborts ALL test cases. The second test case
> (FAN_REPORT_PIDFD | FAN_REPORT_FID | FAN_REPORT_DFID_NAME expected to
> succeed) is still valid on v7.2+ but will never run.
> 
> Should this be a per-test-case skip instead, so that only the EINVAL
> case is skipped on v7.2+?

This observation is correct. If v7.2+ enabled only pidfd + tid combination
for fanotify, we should not skip pidfd + fid. The 1/5 patch needs to be
updated to use a per tcase TCONF.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp