Re: [LTP] cgroup/cgroup_core03: convert to new LTP API with parameterised subtests

Hi Yeswanth,

On Fri, 31 Jul 2026, Yeswanth Krishna Tellakula wrote:
> cgroup/cgroup_core03: convert to new LTP API with parameterised subtests

> 	if (n == 0) {
> 		*data_ptr = 0;
> 		num_pids = PID_NUM;
>
> 		for (i = 0; i < num_pids; i++)
> 			pids[i] = cg_run_nowait(cg_child);
>
> 		TST_CHECKPOINT_WAIT(0);
> 	}

High: How can subtest 0 return while these children remain paused? After each
.test callback, the LTP framework calls tst_reap_children(). It will block
waiting for the children before run(1) can write to cgroup.kill, so the test
always times out after subtest 0. Could the dependent sequence remain in one
.test_all callback instead?

> The test used the old .test_all single-function style. Convert it to
> the new parameterised .test/.tcnt API
>
> No functional behaviour change.

Medium: Could this rationale be corrected? .test_all is already part of the
new API, and changing to .test materially changes execution because the
framework reaps children after every callback.

>  * [Description]

Low: Could this deprecated header be removed? LTP test descriptions must not
use [Description].

> 	.needs_root = 1,

Low: Could the test description explain why root privileges are required, as
required for tests setting .needs_root?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp