Hi Frank,
On Aug 13, 2026, Frank Ranner wrote:
> testcases/kernel/crypto/crypto_user02.c: fix hmac candidate probing
> Fixes: a4be708b4 ("testcases/kernel/crypto/crypto_user02.c: try non-generic hmac names first")
Medium: Could this use c05a44cf1 instead? The referenced a4be708b4 does not
resolve to a commit in the local LTP history, while c05a44cf1 has the quoted
subject.
> + /* find out which driver actually satisfies this name */
> + memset(&report, 0, sizeof(report));
> + strcpy(report.cru_name, ALGORITHM_CANDIDATES[i]);
> + if (tst_crypto_get_alg(ctx, &report) != 0)
Low: Could this comment be removed? It only restates the
tst_crypto_get_alg() call, while LTP comments should explain why rather than
narrate the code.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.