Re: [LTP] [PATCH v5 3/7] lib: Add support for max_kver to struct tst_test and tst_fs

> Hi!
> > You're probably right. When I started this there were 3 tests and I thought there
> > would be more. I also thought this would be useful info in the metadata.  But
> > in later versions it turn out 2 of them are to be removed. Now I double checked
> > "tst_kvercmp >" code and it looks like none of them applies to .max_kver usage.
> > I agree that a single test is not enough as a reason to have it in the metadata.
> > Maybe there will be more in the future, but really just a few.

> I would set the threshold at at least two tests needs this. If the
> functionality is used only by one test, it's likely not worth adding the
> API.

+1

> > => I should probably send yet another version where I implement the skip in the
> > setup. Could you please comment these 2 commits (I would not resend them)?

> Which ones?

I'm about to merge the original approach for fanotify20 (just to join split
string):
https://lore.kernel.org/ltp/[email protected]/

I guess these 2 could be merged:
https://lore.kernel.org/ltp/[email protected]/
https://lore.kernel.org/ltp/[email protected]/

And then we are done with the test fixes, I wonder if it's worth to add
lib/newlib_tests/tst_max_kver_old.c (only this one) from this patchset

https://lore.kernel.org/ltp/[email protected]/

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp