Re: [LTP] [PATCH v5 3/7] lib: Add support for max_kver to struct tst_test and tst_fs

Hi Cyril,

> Hi!
> > > Which ones?

> > I'm about to merge the original approach for fanotify20 (just to join split
> > string):
> > https://lore.kernel.org/ltp/[email protected]/

> Yes please. Feel free to add my Reviewed-by:

I'm very sorry, I read this after merging the original solution:
936dc02725 ("fanotify20: Skip FAN_REPORT_PIDFD | FAN_REPORT_TID test on v7.2+")

Next time I double check my mailbox before merging (I have checked the patch
itself).

> > I guess these 2 could be merged:
> > https://lore.kernel.org/ltp/[email protected]/
> > https://lore.kernel.org/ltp/[email protected]/

> Reviewed.

Thank you (merged).

> > And then we are done with the test fixes, I wonder if it's worth to add
> > lib/newlib_tests/tst_max_kver_old.c (only this one) from this patchset

> > https://lore.kernel.org/ltp/[email protected]/

> So you stil want to add .max_kver to the tst_test structure?

No, at least not now. We really have only single test to be used (fanotify20.c),
for which I have merged the original approach.

Let's see in the future if more tests need it. From the docs point it'd be nice
to have it, but you were right that one test is really not enough. Also whole
discussions about the ideal functionality are waste of time for a single test.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp