Re: [LTP] lib: Add tst_sysfs_assert

Hi Cyril,

On Wed, 19 Aug 2026 18:16:04 +0200, Cyril Hrubis wrote:
> lib: Add tst_sysfs_assert

--- [PATCH 1/31] ---

> +/**
> + * tst_sysfs_exists() - Checks whether a file exists.
> + *
> + *
> + * @fmt: A printf-like format to build a path to the file.
> + * @...: A printf-like parameters for fmt.
> + * return: 1 if the file at the path built from fmt exists, 0 otherwise.
> + */

Since kernel-doc section labels are case-sensitive, should this be "Return:"
(capital R) instead of "return:"?

Could the stray blank " *" line between the summary and the @parameters
also be removed?

--- [PATCH 14/31] ---

> testcases: sysfs: sys_hwmon01

Could the subject describe the change by adding "Add", consistently with
the other test-adding commits in the series, i.e.
"testcases: sysfs: Add sys_hwmon01"?

--- [PATCH 15/31] ---

> testcases: sysfs: sys_leds01

Could "Add" be included here as well, i.e.
"testcases: sysfs: Add sys_leds01"?

--- [PATCH 19/31] ---

> +/*
> + * Change the link-layer (MAC) address of an existing network device.
> ...
> +int tst_netdev_set_hwaddr(const char *file, const int lineno, int strict,
> +	const char *ifname, const void *addr, size_t addrlen);

> +/*
> + * Enslave ifname to the master_ifname device, e.g. add it as a bridge
> ...
> +int tst_netdev_set_master(const char *file, const int lineno, int strict,
> +	const char *ifname, const char *master_ifname);

Could both new public functions use kernel-doc /** comments instead of
plain /* comments so they appear in the generated API documentation?

--- [PATCH 22/31] ---

> Similar to sys_net02 but checks bridge related files after briding a
> virtual ethernet interface.

Could "briding" be changed to "bridging"?

--- [PATCH 23/31] ---

> +static void cleanup(void)
> +{
> +	if (tun_fd >= 0)
> +		SAFE_CLOSE(tun_fd);
> +
> +	if (tap_fd >= 0)
> +		SAFE_CLOSE(tap_fd);

Since both variables are initialized to -1, could these guards use the LTP
"fd != -1" convention instead of "fd >= 0"?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp