Re: [Buildroot] [PATCH v2] package/libcppconnman: add new package
Andrea Ricchi <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <CABNF3=YJ4+mUh1tpnYcjk=J+uTRt8+2+izPNdRUL0WP4WbioWQ@mail.gmail.com> |
Hi Julien, Thanks a lot for the review. I am currently fixing the issues reported, including the build failures and the missing readline dependency for the examples. I will send the v3 patch as soon as it is ready. Thanks, Andrea Ricchi Embedded Software Engineer M. +39 333 775 4973 [email protected] ――――――――――――――― Amarula Solutions SRL Via Felice Cavallotti 25D, 41012 Carpi, MO, IT [email protected] www.amarulasolutions.com On Sun, Jul 19, 2026 at 3:16 PM Julien Olivain <[email protected]> wrote: > Hi Andrea, > > Thanks for the patch. > > The package introduces build failures for some toolchains. See: > https://gitlab.com/jolivain/buildroot/-/pipelines/2688533526 > > You can reproduce locally with the command: > utils/test-pkg -a -p libcppconnman > > I have another comment, see below. > > On 17/07/2026 11:32, Andrea Ricchi wrote: > > libcppconnman is a C++ library that provides an easy-to-use API > > to communicate with ConnMan over D-Bus using GDBus. > > > > https://github.com/amarula/libcppconnman > > > > Also add myself to DEVELOPERS for this package. > > > > Signed-off-by: Andrea Ricchi <[email protected]> > > --- > > Changes v1 -> v2: > > - add missing libcppconnman entry in package/Config.in > > - merge the DEVELOPERS addition into this patch > > > > DEVELOPERS | 1 + > > package/Config.in | 1 + > > package/libcppconnman/Config.in | 26 ++++++++++++++++++++++++ > > package/libcppconnman/libcppconnman.hash | 3 +++ > > package/libcppconnman/libcppconnman.mk | 24 ++++++++++++++++++++++ > > 5 files changed, 55 insertions(+) > > create mode 100644 package/libcppconnman/Config.in > > create mode 100644 package/libcppconnman/libcppconnman.hash > > create mode 100644 package/libcppconnman/libcppconnman.mk > > > [...] > > diff --git a/package/libcppconnman/Config.in > > b/package/libcppconnman/Config.in > > new file mode 100644 > > index 0000000000..19dc0bbd2d > > --- /dev/null > > +++ b/package/libcppconnman/Config.in > > @@ -0,0 +1,26 @@ > > +config BR2_PACKAGE_LIBCPPCONNMAN > > + bool "libcppconnman" > > + depends on BR2_INSTALL_LIBSTDCPP > > + depends on BR2_USE_WCHAR # libglib2 > > + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > > + depends on BR2_USE_MMU # libglib2 > > + select BR2_PACKAGE_LIBGLIB2 > > + help > > + libcppconnman provide easy to use C++ API to communicate > > + with ConnMan via the DBus using GDBus. > > + > > + https://amarula.github.io/libcppconnman/ > > + > > +comment "libcppconnman needs a toolchain w/ C++, wchar, threads" > > + depends on BR2_USE_MMU > > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > > + !BR2_TOOLCHAIN_HAS_THREADS > > + > > +if BR2_PACKAGE_LIBCPPCONNMAN > > + > > +config BR2_PACKAGE_LIBCPPCONNMAN_EXAMPLE > > + bool "libcppconnman example" > > When configuring with examples, package build configuration fails with > a missing readline library. You can reproduce with: > > cat >.config <<EOF > BR2_aarch64=y > BR2_TOOLCHAIN_EXTERNAL=y > BR2_PACKAGE_LIBCPPCONNMAN=y > BR2_PACKAGE_LIBCPPCONNMAN_EXAMPLE=y > EOF > make olddefconfig > make libcppconnman > > Could you add this missing dependency (both in Config.in and in the .mk > file) > please? > > > + help > > + Compile CLI example. > > + > > +endif > > Could you send an updated patch fixing those issues, please? > > Best regards, > > Julien. > _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot