Re: [Buildroot] [PATCH v4 3/3] package/drogon: new package

Hi Dario,

> Drogon is a C++17/20 based HTTP application framework. It can be used to
> easily build various types of web application server programs using C++.

> Project page: https://github.com/drogonframework/drogon

...
> diff --git a/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch b/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch
> new file mode 100644
> index 000000000000..7a9fab389fec
> --- /dev/null
> +++ b/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch
> @@ -0,0 +1,93 @@
> +From 9ecfb965e6ea02583874e534f8936ebb43a9db29 Mon Sep 17 00:00:00 2001
> +From: Dario Binacchi <[email protected]>
> +Date: Mon, 20 Jul 2026 16:16:22 +0200
> +Subject: [PATCH] Fix EPOLLRDHUP/POLLRDHUP mismatch on Linux SPARC/SPARC64
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fix a build failure reported by Buildroot autobuild for the
> +bootlin-sparc64-glibc configuration:
> +
> +  EpollPoller.cc:41:26: error: static assertion failed:
> +  EPOLLRDHUP != POLLRDHUP
> +
> +On SPARC/SPARC64, EPOLLRDHUP (0x2000) and POLLRDHUP (0x0800) are
> +different bits, breaking the assumption elsewhere in this file that
> +epoll and poll flags are interchangeable.
> +
> +Introduce a combined RDHUP value for this architecture and translate
> +it before epoll_ctl() and after epoll_wait(), since revents_ is later
> +tested against POLLRDHUP in Channel::handleEvent() — otherwise
> +half-close detection would silently break at runtime.
> +
> +This patch is inspired by the equivalent fix in lighttpd:
> +https://redmine.lighttpd.net/issues/3251
> +
> +Signed-off-by: Dario Binacchi <[email protected]>
> +Upstream: https://github.com/an-tao/trantor/pull/407

I'm not sure what is the Buildroot's approach for git submodules.
As you use tallbar it should be ok like this (i.e. not adding trantor as a
separate package). Also other would probably raise a concern).

Otherwise LGTM.
Reviewed-by: Petr Vorel <[email protected]>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot