Re: [Buildroot] [PATCH 2/3] package/bitcoin: Fix build without SSP

In reply of:
> Buildroot commit fabcd7c8cc44e7e03c68bfcd2b4e2d10331a93f6 bumped the
> package from 28.0 to 30.0 which includes upstream commit
> https://github.com/bitcoin/bitcoin/commit/a01cb6e63ff3940f0773b37e2fe1e148f17acad9
> that was first included in version 29.0 and added among others
> -fstack-protector-all to cxx_flags guarded with a new configure option
> ENABLE_HARDENING which default to ON.
> 
> This commit causes build errors with toolchains with SSP support:
> 
> [ 44%] Linking CXX executable ../bin/bitcoin
> /home/autobuild/autobuild/instance-40/output-1/host/lib/gcc/i686-buildroot-linux-musl/15.2.0/../../../../i686-buildroot-linux-musl/bin/ld:
>  CMakeFiles/bitcoin.dir/bitcoin.cpp.o:
>  in function `fs::PathToString(fs::path const&)':
> bitcoin.cpp:(.text+0x4c):
>  undefined reference to `__stack_chk_fail_local'
> 
> Upstream later removed the forementioned configure option with commit
> https://github.com/bitcoin/bitcoin/commit/00ba3ba30341a9073049125334f176d6c05d1b54
> that was first included in version 30.0 so we need to remove
> -fstack-protector-all from CMakeLists.txt.
> 
> Fixes:
> https://autobuild.buildroot.net/results/093/093253c79fed1c5b93decc3124e9ef4622168efe/
> 
> Signed-off-by: Bernd Kuhls <[email protected]>

Applied to 2026.05.x. Thanks

> ---
> Gitlab pipelines passed:
> https://gitlab.com/bkuhls/buildroot/-/commits/8d17d8107a074b94d628061a3c18917987141483
> 
>  ...sts.txt-Don-t-force-fstack-protector.patch | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/bitcoin/0002-CMakeLists.txt-Don-t-force-fstack-protector.patch
> 
> diff --git a/package/bitcoin/0002-CMakeLists.txt-Don-t-force-fstack-protector.patch b/package/bitcoin/0002-CMakeLists.txt-Don-t-force-fstack-protector.patch
> new file mode 100644
> index 0000000000..40370d1bf7
> --- /dev/null
> +++ b/package/bitcoin/0002-CMakeLists.txt-Don-t-force-fstack-protector.patch
> @@ -0,0 +1,30 @@
> +From 4d33b5bcc924c9271c40a19796f8316ba6aaa276 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <[email protected]>
> +Date: Sat, 18 Jul 2026 08:10:21 +0200
> +Subject: [PATCH] CMakeLists.txt: Don't force -fstack-protector
> +
> +This allows the environment to decide whether SSP should be used or
> +not, for example to support toolchains that don't have SSP support.
> +
> +Upstream: N/A Buildroot specific
> +
> +Signed-off-by: Bernd Kuhls <[email protected]>
> +---
> + CMakeLists.txt | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index 892f30d94b..93ccbf71ec 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -532,7 +532,6 @@ else()
> +   unset(cxx_supports_fortify_source)
> + 
> +   try_append_cxx_flags("-Wstack-protector" TARGET core_interface SKIP_LINK)
> +-  try_append_cxx_flags("-fstack-protector-all" TARGET core_interface)
> +   try_append_cxx_flags("-fcf-protection=full" TARGET core_interface)
> + 
> +   if(MINGW)
> +-- 
> +2.47.3
> +
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> [email protected]
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot