Re: [Buildroot] [PATCH 1/1] package/cpp-argparse: new package

Hi Konstantin,

Thanks for the patch. I have few comments, see below.

On 29/07/2026 17:26, [email protected] wrote:
> From: Konstantin Menyaev <[email protected]>
> 
> A Modern C++ header-only library
> for parsing command-line arguments.
> 
> https: //github.com/p-ranav/argparse
> 
> Signed-off-by: Konstantin Menyaev <[email protected]>
> ---
>  package/Config.in                    |  1 +
>  package/cpp-argparse/Config.in       | 12 ++++++++++++
>  package/cpp-argparse/cpp-argparse.mk | 16 ++++++++++++++++
>  3 files changed, 29 insertions(+)
>  create mode 100644 package/cpp-argparse/Config.in
>  create mode 100644 package/cpp-argparse/cpp-argparse.mk

Your submission misses the cpp-argparse.hash file. Could you add
it please? See:
https://nightly.buildroot.org/manual.html#adding-packages-hash

You can check that with commands:

make cpp-argparse-source
WARNING: no hash file for cpp-argparse-v3.2.tar.gz

make cpp-argparse-legal-info
WARNING: no hash file for LICENSE

[...]
> diff --git a/package/cpp-argparse/Config.in 
> b/package/cpp-argparse/Config.in
> new file mode 100644
> index 0000000000..7ad91f7bbc
> --- /dev/null
> +++ b/package/cpp-argparse/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_CPP_ARGPARSE
> +	bool "cpp-argparse"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7

Upstream says the package requires gcc >= 8. Could you align to
this version please?
https://github.com/p-ranav/argparse/blob/v3.2/README.md?plain=1#L1432

> +	help
> +	  Argument Parser for Modern C++. A header-only library
> +	  for parsing command-line arguments.
> +
> +	  https://github.com/p-ranav/argparse
> +
> +comment "cpp-argparse needs a toolchain w/ C++, GCC >= 7"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_7

Please adjust the gcc version here too.

> diff --git a/package/cpp-argparse/cpp-argparse.mk 
> b/package/cpp-argparse/cpp-argparse.mk
> new file mode 100644
> index 0000000000..7978fd224c
> --- /dev/null
> +++ b/package/cpp-argparse/cpp-argparse.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# cpp-argparse
> +#
> +################################################################################
> +
> +CPP_ARGPARSE_VERSION = v3.2
> +CPP_ARGPARSE_SITE = $(call 
> github,p-ranav,argparse,$(CPP_ARGPARSE_VERSION))

For automated release monitoring, could you please move the 'v'
to _SITE to have instead:

CPP_ARGPARSE_VERSION = 3.2
CPP_ARGPARSE_SITE = $(call 
github,p-ranav,argparse,v$(CPP_ARGPARSE_VERSION))

> +CPP_ARGPARSE_LICENSE = MIT
> +CPP_ARGPARSE_LICENSE_FILES = LICENSE
> +CPP_ARGPARSE_INSTALL_STAGING = YES
> +CPP_ARGPARSE_INSTALL_TARGET = NO
> +
> +CPP_ARGPARSE_CONF_OPTS = -DARGPARSE_BUILD_SAMPLES=OFF 
> -DARGPARSE_BUILD_TESTS=OFF
> +
> +$(eval $(cmake-package))
> --
> 2.55.0

Could you send an updated patch addressing those comments, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot