Re: [Buildroot] [PATCH v3 1/1] package/xen: fix build error when BR2_PACKAGE_XEN_TOOLS not enabled

Neal,

> -----Original Message-----
> From: John Ernberg <[email protected]> 
> Sent: Monday, August 3, 2026 7:33 AM
> To: Neal Frager <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Wood (US), Brian J <[email protected]>; Weber (US), Matthew L <[email protected]>; [email protected]; [email protected]; [email protected]
> Subject: [EXTERNAL] Re: [PATCH v3 1/1] package/xen: fix build error when BR2_PACKAGE_XEN_TOOLS not enabled> 
> EXT email: be mindful of links/attachments.> 
> 
> 
> Hi Neal,> 
> On 8/3/26 12:29 PM, Neal Frager wrote:
> > The 0002-Update-linker-flags.patch assumes that the qemu-xen files are 
> > included in the xen source tree. However, if BR2_PACKAGE_XEN_TOOLS is 
> > not enabled, the qemu-xen dependency will not be handled and the patch 
> > will fail to apply with the following error.
> > 
> > Fixes: build error below
> > Applying 0002-Update-linker-flags.patch using patch:
> > patching file tools/Makefile
> > Hunk #1 succeeded at 36 (offset -1 lines).
> > Hunk #2 succeeded at 185 (offset -8 lines).
> > can't find file to patch at input line 76 Perhaps you used the wrong 
> > -p or --strip option?
> > The text leading up to this was:
> > --------------------------
> > |diff --git a/tools/qemu-xen/include/hw/xen/xen_native.h 
> > |b/tools/qemu-xen/include/hw/xen/xen_native.h
> > |index 6bcc83ba..2590904e 100644
> > |--- a/tools/qemu-xen/include/hw/xen/xen_native.h
> > |+++ b/tools/qemu-xen/include/hw/xen/xen_native.h
> > --------------------------
> > No file to patch.  Skipping patch.
> > 1 out of 1 hunk ignored
> > make: *** [package/pkg-generic.mk:239: 
> > output/build/xen-4.21.1/.stamp_patched] Error 1
> > 
> > To avoid making BR2_PACKAGE_XEN_TOOLS a required option, fix the 
> > 0002-Update-linker-flags.patch so that the part that modifies the 
> > qemu-xen sources is correctly moved to a patch in the qemu-xen package.
> > 
> > Move this:
> >   #define QEMU_HW_XEN_NATIVE_H
> > 
> >   #ifdef __XEN_INTERFACE_VERSION__
> > -#error In Xen native files, include xen_native.h before other Xen 
> > headers
> > +#warning In Xen native files, include xen_native.h before other Xen 
> > +headers
> >   #endif
> > 
> >   /*
> > 
> > to package/qemu-xen/0001-Update-linker-flags.patch.
> > 
> > To test:
> > BR2_aarch64=y
> > BR2_TOOLCHAIN_EXTERNAL=y
> > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y
> > BR2_PACKAGE_XEN=y
> > 
> > Signed-off-by: Neal Frager <[email protected]>
>
> Reviewed-by: John Ernberg <[email protected]>

Tested-by: Matthew Weber <[email protected]>

Verified hypervisor-only build (XEN=y, XEN_TOOLS not set) on aarch64
with Bootlin external toolchain. The check-package was also clean.

Regards,
Matt

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot