Re: [Buildroot] [EXTERNAL] [PATCH v4 2/4] package/xen: add custom version support

AMD General

Hi Matt,

>
>  Add the ability to configure specific Xen versions while leaving the default version unchanged to avoid breaking any builds already using Xen 4.21.1.

> I think there is an edge case that if the user's custom tarball or GIT repo selects XEN_TOOLS and contains the qemu-xen folder with a cached set of files those won't be used.  We currently unconditionally do the following in xen.mk.

> define XEN_INSTALL_QEMU_XEN_SRC
>       rm -rf $(@D)/tools/qemu-xen
>       cp -a $(QEMU_XEN_DIR) $(@D)/tools/qemu-xen
> endef

> I don't think this edge case is worth considering at this point and if someone runs into it, they could add a new check for existence of that folder and fail out.  Or determine a better option.

I thought of the same potential issue.

I do have a test case with mixing versions.  At the moment, Xilinx has a
vendor/custom xen repo, but there is not a vendor/custom qemu-xen repo.
In my testing, I verified that a combination of the Xilinx xen repo builds
properly with the upstream qemu-xen repo from the qemu-xen package.

I know this is just one test case, but the fact that the xen and qemu-xen
repos are separated, it should mean that we can mix and match the versions
between the two repos.  In other words, if someone builds xen with a cached
qemu-xen, it will probably still build and work when the xen package wipes
the cached qemu-xen version and replaces it with the buildroot qemu-xen
package version.

Before we overthink it and add code that might not be necessary, I propose
we wait and see if a user ever does run into a case where replacing the cached
qemu-xen version with the buildroot qemu-xen package version causes a problem.

Perhaps we can try testing some older xen versions without touching the
qemu-xen package as a sanity check?  Is this something you could do?

Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot