Re: [Buildroot] [PATCH v2] package/libglib2: disable sysprof for the host build

Am 07.06.26 um 10:58 schrieb Jean-Michel Hautbois:
> Whether the host libglib2 picks up sysprof support depends on whether
> libsysprof-capture happens to be installed on the build machine, which
> makes the host build depend on the host environment. Disable sysprof
> explicitly for the host build so the result is deterministic.
> 
> Keep sysprof enabled for the target build: it is useful to profile and
> measure the performance of applications running on the target.
> 
> Signed-off-by: Jean-Michel Hautbois <[email protected]>

Applied to master, thank you. I've modified the patch to make the same 
change in package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk.

Ideally we should explicitly set the sysprof option for the target 
build, too, rather than letting autodetection do its thing. I see that 
package/sysprof depends on libglib2 though, so there might be a 
dependency loop. Maybe you or Adrian could look into that?

Best regards,
Fiona

> ---
> Changes since v1:
>   - Disable sysprof only for the host build (HOST_LIBGLIB2_CONF_OPTS)
>     instead of disabling it globally, keeping it available on the
>     target, as suggested by Adrian Perez de Castro.
>   - Reword the commit message accordingly.
> 
>   package/libglib2/libglib2.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
> index cae8a85a28..ae4b653a15 100644
> --- a/package/libglib2/libglib2.mk
> +++ b/package/libglib2/libglib2.mk
> @@ -30,7 +30,8 @@ HOST_LIBGLIB2_CONF_OPTS = \
>   	-Dsystemtap=false \
>   	-Dxattr=false \
>   	-Dtests=false \
> -	-Doss_fuzz=disabled
> +	-Doss_fuzz=disabled \
> +	-Dsysprof=disabled
>   
>   LIBGLIB2_DEPENDENCIES = \
>   	host-pkgconf host-libglib2 \

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot