Re: [Buildroot] [PATCH 1/1] package/apr: fix build failure with GCC >= 14
Romain Naour via buildroot <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <[email protected]> |
Hello Fiona, Bernd, All, Le 03/07/2026 à 20:49, Bernd Kuhls a écrit : > Am Fri, 3 Jul 2026 20:03:54 +0200 schrieb Fiona Klute via buildroot: > >> The workaround in 3d06661fc1bf0f88356981a44cb93b7b0c76a669 for the >> broken C23 check was incorrect: When overriding ac_cv_prog_cc_c23 the >> value must either be "no" (to indicate that C23 is not supported) or >> contain the command line parameters to enable C23 with the C compiler in >> use (e.g. "-std=gnu23", may be an empty string if appropriate). The >> workaround set it to "yes" for host GCC >= 14, making builds fail. >> >> However, the original issue was that apr may try to enable C23 in host >> CC calls if the target CC supports it. So instead of figuring out the >> correct arguments for GCC >= 14, we can set ac_cv_prog_cc_c23=no only >> for host GCC <= 13 and leave it unset otherwise, as in that case >> enabling C23 will do no harm. >> >> Fixes: 3d06661fc1bf0f88356981a44cb93b7b0c76a669 Fixes: >> - >> https://autobuild.buildroot.net/results/77c/ > 77cd5456169e04c2f92dc328c4b6828513d1195f/ >> - >> https://autobuild.buildroot.net/results/ > 7a4/7a4fb2b21027f98df607871d9fe0dd234d44aebb/ >> - >> https://autobuild.buildroot.net/results/a6c/ > a6cef4c5965fdeb40d3b39cbd40941329f4fc1c8/ >> (and more) >> >> Signed-off-by: Fiona Klute <[email protected]> > > Tested-by: Bernd Kuhls <[email protected]> > [build-tested, previous build error seen here is now fixed] Thanks for the fix! The use of ac_cv_prog_cc_c23='-std=gnu23' instead of ac_cv_prog_cc_c23=yes it unintuitive since we can use ac_cv_prog_cc_c23=no to disable the feature. But ok, we (with Dowan) failed to test the initial fix properly due to an excessive use of Docker environment ;-) Applied to master. Thanks. Best regards, Romain > > _______________________________________________ > buildroot mailing list > [email protected] > https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot