[Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies

Thomas Petazzoni via buildroot <[email protected]>
Newsgroups net.busybox.buildroot
Message-ID <[email protected]>
Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic
dependency, but the Config.in comment dependencies are not correct:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+       depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC

Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
dependency in Buildroot, so it should be:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+       depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
false.

Signed-off-by: Thomas Petazzoni <[email protected]>
---
 package/libxmlsec1/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libxmlsec1/Config.in b/package/libxmlsec1/Config.in
index 782e6ced7c..9270447510 100644
--- a/package/libxmlsec1/Config.in
+++ b/package/libxmlsec1/Config.in
@@ -14,4 +14,5 @@ config BR2_PACKAGE_LIBXMLSEC1
 	  https://github.com/lsh123/xmlsec
 
 comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
-	depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
-- 
2.55.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.