Re: [Buildroot] [PATCH v2 2/2] package/wine: select libxkbcommon and libxml2 for the Wayland driver
Thomas Petazzoni via buildroot <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <anji-UrwHCkDrzFm@windsurf> |
Hello, On Sun, Aug 09, 2026 at 04:14:03PM -0400, Alsey Coleman Miller wrote: > wine.mk passes --with-wayland whenever BR2_PACKAGE_WAYLAND is enabled, > but nothing guarantees the rest of what wine's Wayland test needs is in > the configuration. That test is: > > WINE_NOTICE_WITH(wayland, [test -z "$WAYLAND_CLIENT_LIBS" \ > -o -z "$WAYLAND_SCANNER" -o -z "$XKBCOMMON_LIBS" \ > -o -z "$XKBREGISTRY_LIBS" -o "$ac_cv_header_linux_input_h" = "no"], ...) > > and because --with-wayland is passed explicitly, WINE_NOTICE_WITH turns > into AC_MSG_ERROR rather than a notice. > > So wine needs libxkbcommon, and it needs the libxkbregistry part of it, > which is only built when libxml2 is available. Select both when Wayland > support is enabled, and add libxkbcommon to the build dependencies. > > Note that libxml2 is not a direct dependency of wine, it only has to be > in the configuration so that libxkbcommon builds libxkbregistry; the > build ordering is handled by libxkbcommon's own dependency on libxml2. > > Signed-off-by: Alsey Coleman Miller <[email protected]> Thanks for this new iteration! Reviewed-by: Thomas Petazzoni <[email protected]> Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot