Re: [Buildroot] [PATCH] package/libxkbcommon: provide xkbregistry when libxml2 is enabled

Hello Raphaël, All,

Le 06/07/2026 à 17:34, Raphaël Gallais-Pou a écrit :
> 
> 
> On 6/24/26 17:51, Romain Naour wrote:
>> Hello Raphaël,
> 
> Hi,
> 
>>
>> Le 27/05/2026 à 21:53, Raphaël Gallais-Pou a écrit :
>>> xkbregistry is disabled by default.  Yet, it only needs libxml2 to be
>>> built, which is already supported.
>>>
>>> Add the compile flags to build xkbregistry when possible.
>>>
>>> Signed-off-by: Raphaël Gallais-Pou <[email protected]>
>>> ---
>>>   package/libxkbcommon/libxkbcommon.mk | 10 ++++++++--
>>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/libxkbcommon/libxkbcommon.mk b/package/libxkbcommon/
>>> libxkbcommon.mk
>>> index 21a2b937ef02..98154369b419 100644
>>> --- a/package/libxkbcommon/libxkbcommon.mk
>>> +++ b/package/libxkbcommon/libxkbcommon.mk
>>> @@ -12,8 +12,7 @@ LIBXKBCOMMON_CPE_ID_VENDOR = xkbcommon
>>>   LIBXKBCOMMON_INSTALL_STAGING = YES
>>>   LIBXKBCOMMON_DEPENDENCIES = host-bison host-flex
>>>   LIBXKBCOMMON_CONF_OPTS = \
>>> -    -Denable-docs=false \
>>> -    -Denable-xkbregistry=false
>>
>> xkbregistry has been disabled on purpose when libxkbcommon has been updated to
>> 1.0.1 [1].
> 
> Indeed I haven't see this.
> 
>>
>> It seems to requires xkeyboard-config at runtime [2], can you verify?
> 
> Yes: libxkbcommon does not provide dataset, which is what xkeyboard-config is.
> From [2]:
> It is [preferred] that libxkbregistry be split into a separate packages as most
> clients that require libxkbcommon do not require libxkbregistry and clients
> requiring libxkbregistry may not need libxkbcommon.
> 
> Does that mean that a libxkbregistry package needs to be created since it is
> independant from libxkbcommon ?

I don't think so, I'm fine enabling xkbregistry when the optional libxml2
dependency is available, just take care of runtime dependencies. Maybe consider
adding a new sub option for packages that need explicitly libxkbregistry.

libxkbregistry is packaged by libxkbcommon package in Fedora and Yocto, there is
no separate package for it [1][2].

Note: Yocto add xkeyboard-config runtime dependency to libxkbcommon with x11
support, not xkbregistry itself.

Please, send an updated patch.

[1] https://src.fedoraproject.org/rpms/libxkbcommon/blob/f45/f/libxkbcommon.spec#_18

[2]
https://github.com/openembedded/openembedded-core/blob/5d1aa5c806c061a2994f4decb59016610f093213/meta/recipes-graphics/xorg-lib/libxkbcommon_1.13.1.bb#L21

Best regards,
Romain

> 
> Best regards,
> Raphaël
> 
>>
>> [1]
>> https://gitlab.com/buildroot.org/buildroot/-/
>> commit/1791bc30a5b19bb52366375d03e66348242ff25a
>>
>> [2]
>> https://github.com/xkbcommon/libxkbcommon/
>> blob/2c295b10aa87e9bd8c11954adcf7e92b031b92f9/PACKAGING#L61
>>
>> Best regards,
>> Romain
>>
>>> +    -Denable-docs=false
>>>     ifeq ($(BR2_PACKAGE_XORG7),y)
>>>   LIBXKBCOMMON_CONF_OPTS += -Denable-x11=true
>>> @@ -22,6 +21,13 @@ else
>>>   LIBXKBCOMMON_CONF_OPTS += -Denable-x11=false
>>>   endif
>>>   +ifeq ($(BR2_PACKAGE_LIBXML2),y)
>>> +LIBXKBCOMMON_CONF_OPTS += -Denable-xkbregistry=true
>>> +LIBXKBCOMMON_DEPENDENCIES += libxml2
>>> +else
>>> +LIBXKBCOMMON_CONF_OPTS += -Denable-xkbregistry=false
>>> +endif
>>> +
>>>   ifeq ($(BR2_PACKAGE_LIBXKBCOMMON_TOOLS),y)
>>>   LIBXKBCOMMON_CONF_OPTS += -Denable-tools=true
>>>   else
>>>
>>> ---
>>> base-commit: 08f3757b0f2133b0ed50e1ef3d7a5a1d9c80de1c
>>> change-id: 20260527-master-2e5299aaa8ca
>>>
>>> Best regards,
>>> -- 
>>> Raphaël Gallais-Pou <[email protected]>
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> [email protected]
>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
> 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot