[Buildroot] [PATCH 1/3] package/libdvdcss: needs gcc >= 8
Bernd Kuhls <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <[email protected]> |
Buildroot commit cd3a2f0ff35346ad5fd6a9867113260addccf127 switched the build system to meson which depends on c17: https://code.videolan.org/videolan/libdvdcss/-/commit/9f16597859120b96006415c084039f63efc84b83#line_0cc1139e3_A5 Add the necessary dependency and propagate to reverse dependencies to fix a build error caught by the Gitlab pipelines: br-test-pkg/bootlin-aarch64-glibc-old/build/libdvdcss-1.5.0/meson.build:1:0: ERROR: None of values ['c17'] are supported by the C compiler. Possible values for option "c_std" are ['none', 'c89', 'c99', 'c11', 'gnu89', 'gnu99', 'gnu11'] Signed-off-by: Bernd Kuhls <[email protected]> --- Gitlab pipelines passed: https://gitlab.com/bkuhls/buildroot/-/commits/b4f4db5ed78a4121de247715bfb0c4c7d1ca5808 package/dvdauthor/Config.in | 4 ++++ package/gstreamer1/gst1-plugins-ugly/Config.in | 4 ++++ package/libdvdcss/Config.in | 4 ++++ package/libdvdnav/Config.in | 6 ++++-- package/libdvdread/Config.in | 4 ++++ 5 files changed, 20 insertions(+), 2 deletions(-) diff --git a/package/dvdauthor/Config.in b/package/dvdauthor/Config.in index 9ba5411d6b..23477e91e0 100644 --- a/package/dvdauthor/Config.in +++ b/package/dvdauthor/Config.in @@ -17,9 +17,13 @@ if BR2_PACKAGE_DVDAUTHOR config BR2_PACKAGE_DVDAUTHOR_DVDUNAUTHOR bool "dvdunauthor" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread select BR2_PACKAGE_LIBDVDREAD help This option enables the dvdunauthor program, which requires libdvdread. +comment "dvdunauthor needs a toolchain w/ gcc >= 8" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 + endif diff --git a/package/gstreamer1/gst1-plugins-ugly/Config.in b/package/gstreamer1/gst1-plugins-ugly/Config.in index 54766ffa8c..aff495c1ac 100644 --- a/package/gstreamer1/gst1-plugins-ugly/Config.in +++ b/package/gstreamer1/gst1-plugins-ugly/Config.in @@ -35,10 +35,14 @@ comment "plugins with external dependencies (there may be more available)" config BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_DVDREAD bool "dvdread" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread select BR2_PACKAGE_LIBDVDREAD help Access a DVD with dvdread +comment "dvdread needs a toolchain w/ gcc >= 8" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 + config BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_MPEG2DEC bool "mpeg2dec" select BR2_PACKAGE_LIBMPEG2 diff --git a/package/libdvdcss/Config.in b/package/libdvdcss/Config.in index a8c3b84cf5..8e6f6ea984 100644 --- a/package/libdvdcss/Config.in +++ b/package/libdvdcss/Config.in @@ -1,7 +1,11 @@ config BR2_PACKAGE_LIBDVDCSS bool "libdvdcss" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # std=c17 help libdvdcss is a simple library designed for accessing DVDs like a block device without having to bother about the decryption. http://www.videolan.org/developers/libdvdcss.html + +comment "libdvdcss needs a toolchain w/ gcc >= 8" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 diff --git a/package/libdvdnav/Config.in b/package/libdvdnav/Config.in index 77cba5f135..8276e466db 100644 --- a/package/libdvdnav/Config.in +++ b/package/libdvdnav/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBDVDNAV bool "libdvdnav" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss -> libdvdread depends on BR2_TOOLCHAIN_HAS_THREADS select BR2_PACKAGE_LIBDVDREAD help @@ -9,5 +10,6 @@ config BR2_PACKAGE_LIBDVDNAV https://www.videolan.org/developers/libdvdnav.html -comment "libdvdnav needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "libdvdnav needs a toolchain w/ threads, gcc >= 8" + depends on !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_8 diff --git a/package/libdvdread/Config.in b/package/libdvdread/Config.in index 3579054158..efa86a4e38 100644 --- a/package/libdvdread/Config.in +++ b/package/libdvdread/Config.in @@ -1,8 +1,12 @@ config BR2_PACKAGE_LIBDVDREAD bool "libdvdread" + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libdvdcss select BR2_PACKAGE_LIBDVDCSS help libdvdread provides a simple foundation for reading DVD-Video images. https://www.videolan.org/developers/libdvdnav.html + +comment "libdvdread needs a toolchain w/ gcc >= 8" + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 -- 2.47.3 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot