Re: [Buildroot] [PATCH v2 01/11] package/mpd: install provided sample configuration file as mpd.conf

Hello Andreas,

On Thu, Jul 09, 2026 at 01:08:05PM +0200, Andreas Ziegler wrote:
> The configuration file supplied by Buildroot is only a sample; it will not
> start MPD on a default installation. Usually a custom mpd.conf is supplied
> in a rootfs overlay.
> 
> Drop the Buildroot configuration file and install the sample supplied by
> MPD instead, it is more complete, contains useful examples and is updated
> regularly.
> 
> Signed-off-by: Andreas Ziegler <[email protected]>

I am not conviced by this change. Indeed, doc/mpdconf.example in the
mpd code base is basically almost entirely commented out. The options
that are set by our package/mpd/mpd.conf are not set by
doc/mpdconf.example (like log_file, music_directory, etc.).

So I am not sure to understand why doc/mpdconf.example is better, as
it actually doesn't configure anything. The only not commented lines
are:

input {
        plugin "curl"
}

which is clearly a lot less than:

music_directory		"/var/lib/mpd/music"
playlist_directory	"/var/lib/mpd/playlists"
db_file			"/var/lib/mpd/database"
log_file		"/var/log/mpd.log"
pid_file		"/var/run/mpd.pid"
state_file		"/var/lib/mpd/state"
bind_to_address		"any"
bind_to_address		"/var/lib/mpd/socket"

in our mpd.conf.

So overall I don't understand why it is an "improvement". Could you
clarify?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot