Re: [Buildroot] [PATCH v2 04/11] support/testing: add test data for mpd (1/6)
Andreas Ziegler <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <[email protected]> |
Hi Thomas, Everyone, On 2026-08-15 19:41, Thomas Petazzoni wrote: > Hello Andreas, > > On Thu, Jul 09, 2026 at 01:08:08PM +0200, Andreas Ziegler wrote: >> Signed-off-by: Andreas Ziegler <[email protected]> >> --- >> Changes v1 -> v2: >> separate test data from test scripts >> create archive chunks of test data that are re-combined during build > > I am sorry but unfortunately, I disagree with the addition of such > significant obscure binary blobs in Buildroot, for two reasons: > > 1. It adds a significant weight (in terms of size) to Buildroot if > each and every test comes with 1 MB of test data > > 2. There is no way to know/verify what this obscure binary data > is. When I saw your patches the immediate thing that came to my > mind is: "it looks like the xz backdoor where some obscure test > data was used to sneak in some malicious code". > > So I don't know what this data is, but instead you have two options: > > 1. Generate it at run-time during the test, if at all possible > > 2. Create a Buildroot package that downloads test data. "mpd" probably > needs music, so you can create a Buildroot package in a > br2-external inside the mpd test that downloads a bunch of music > files, and puts them inside the test root filesystem. I will put the test data in a repository and download it during the build. It needs to be present at the start of the system, otherwise more effort is needed to integrate it. Any reason to use a complete package? Download via post-build.sh could also be an option ... > Best regards, > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com Kind regards, Andreas _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot