Re: [Buildroot] [PATCH] package/openssh: enable DES when using libopenssl

>>>>> "Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

 > So basically, the idea is that if we have OpenSSL, we don't have
 > crypt(), but we have DES_crypt, then we use DES_crypt() as
 > crypt(). Otherwise, the crypt() call in the OpenSSH xcrypt() function
 > remains crypt(), and things blow up when you're building with glibc
 > and you don't have libxcrypt around to provide crypt().

 > So indeed, we have two options here:

 > - Always provide a crypt() implementation by making libxcrypt
 >   mandatory for OpenSSH as a whole, not just for the server-side

 > - Require OpenSSH to provide DES support, which is what Jimmy was
 >   proposing.

 > I honestly don't have a strong argument. My vague feeling is that DES
 > being obsolete, it feels odd to be forced to enable it. Though perhaps
 > libxcrypt would in fact provide exactly the same obsolete crypto
 > algorithm?

 > Peter: thoughts?

I am not sure what openssh uses crypt() for exactly when the server is
not built, but perhaps it just ends up building a bit too much?

Anyway, given that we already use libxcrypt for the server part and
libxcrypt supports a bunch of other algorithmns than just legacy DES, I
think it makes sense to just move the libxcrypt select to the main
option instead.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot